Skip to contentSkip to conversation

remove drivers/net/eepro100.c

RFC PATCH In review Adrian Bunk 7 participants 13 messages Jan 5, 2006 – Jan 18, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 remove drivers/net/eepro100.c

This patch removes the obsolete drivers/net/eepro100.c driver.

Is there any known problem in e100 still preventing us from removing this driver (it seems noone was able anymore to verify the ARM problem)?

---

This patch was already sent on:
- 18 Nov 2005

 MAINTAINERS            |    5 
 drivers/net/Kconfig    |   14 
 drivers/net/Makefile   |    1 
 drivers/net/eepro100.c | 2412 -----------------------------------------
 4 files changed, 2432 deletions(-)
MAINTAINERS renamed from MAINTAINERS.old +0 -5
@@ -868,11 +868,6 @@
 W:	http://ebtables.sourceforge.net/
 S:	Maintained
 
-EEPRO100 NETWORK DRIVER
-P:	Andrey V. Savochkin
-M:	[email protected]
-S:	Maintained
-
 EMU10K1 SOUND DRIVER
 P:	James Courtier-Dutton
 M:	[email protected]
drivers/net/Kconfig renamed from drivers/net/Kconfig.old +0 -14
@@ -1405,20 +1405,6 @@
 	  <file:Documentation/networking/net-modules.txt>.  The module
 	  will be called dgrs.
 
-config EEPRO100
-	tristate "EtherExpressPro/100 support (eepro100, original Becker driver)"
-	depends on NET_PCI && PCI
-	select MII
-	help
-	  If you have an Intel EtherExpress PRO/100 PCI network (Ethernet)
-	  card, say Y and read the Ethernet-HOWTO, available from
-	  <http://www.tldp.org/docs.html#howto>.
-
-	  To compile this driver as a module, choose M here and read
-	  <file:Documentation/networking/net-modules.txt>.  The module
-	  will be called eepro100.
-
-
 config E100
 	tristate "Intel(R) PRO/100+ support"
 	depends on NET_PCI && PCI
drivers/net/Makefile renamed from drivers/net/Makefile.old +0 -1
@@ -40,7 +40,6 @@
 obj-$(CONFIG_TYPHOON) += typhoon.o
 obj-$(CONFIG_NE2K_PCI) += ne2k-pci.o 8390.o
 obj-$(CONFIG_PCNET32) += pcnet32.o
-obj-$(CONFIG_EEPRO100) += eepro100.o
 obj-$(CONFIG_E100) += e100.o
 obj-$(CONFIG_TLAN) += tlan.o
 obj-$(CONFIG_EPIC100) += epic100.o
drivers/net/eepro100.c deleted +0 -2412

2,412 lines not on this page · raw message

#1 lore raw
Quoted 3 lines · Adrian Bunk

This patch removes the obsolete drivers/net/eepro100.c driver.

Is there any known problem in e100 still preventing us from removing this driver (it seems noone was able anymore to verify the ARM problem)?

Still waiting to see if e100 in -mm works on ARM.

Jeff

#2 lore raw
Quoted 6 lines · Jeff Garzik
Quoted 4 lines

This patch removes the obsolete drivers/net/eepro100.c driver.

Is there any known problem in e100 still preventing us from removing this driver (it seems noone was able anymore to verify the ARM problem)?

Still waiting to see if e100 in -mm works on ARM.

e100 seems to work okay on the (modern) ARM CPUs I've tried. The case where e100 failed but eepro100 worked was (I think) on older ARM hardware, and I'm not sure whether that kind of hardware is used anymore..

cheers,
Lennert

#3 lore raw
Quoted 4 lines · Lennert Buytenhek
Quoted 2 lines · Jeff Garzik
Quoted 2 lines

This patch removes the obsolete drivers/net/eepro100.c driver.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Is there any known problem in e100 still preventing us from removing this driver (it seems noone was able anymore to verify the ARM problem)?

Still waiting to see if e100 in -mm works on ARM.

e100 seems to work okay on the (modern) ARM CPUs I've tried. The case where e100 failed but eepro100 worked was (I think) on older ARM hardware, and I'm not sure whether that kind of hardware is used anymore..

Jeff, is this enough to accept my patch?

Quoted 2 lines

cheers,
Lennert

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
In reply to Adrian Bunk
Quoted 5 lines · On Thu, 5 Jan 2006 19:18:26 +0100 Adrian Bunk <[email protected]> wrote:

This patch removes the obsolete drivers/net/eepro100.c driver.

Is there any known problem in e100 still preventing us from removing this driver (it seems noone was able anymore to verify the ARM problem)?

I think I am recalling some problems on ppc82xx, when e100 was stuck on startup, and eepro100 worked just fine.

Even if the patch below will be scheduled for application, we need to set up enough time
for approval that e100 will be fine for all the up-to-date hw; or it should be fixed/updated before eepro100 removal.

Quoted 4 lines
Signature · 2 lines
Sincerely, 
Vitaly
#5 lore raw
Quoted 5 lines · On Sun, 15 Jan 2006 16:19:58 +0300 Vitaly Bordug <[email protected]> wrote:
Quoted 2 lines · On Thu, 5 Jan 2006 19:18:26 +0100 Adrian Bunk <[email protected]> wrote:

This patch removes the obsolete drivers/net/eepro100.c driver.

Quoted 13 lines
Quoted 3 lines

Is there any known problem in e100 still preventing us from removing this driver (it seems noone was able anymore to verify the ARM problem)?

I think I am recalling some problems on ppc82xx, when e100 was stuck on startup, and eepro100 worked just fine.

Even if the patch below will be scheduled for application, we need to set up enough time
for approval that e100 will be fine for all the up-to-date hw; or it should be fixed/updated before eepro100 removal.

Quoted 4 lines

How about doing what was done with devfs removal, and remove it from the config menu system for a couple of releases.

#12 lore raw
In reply to Vitaly Bordug
Quoted 5 lines · Vitaly Bordug
Quoted 2 lines · On Thu, 5 Jan 2006 19:18:26 +0100 Adrian Bunk <[email protected]> wrote:

This patch removes the obsolete drivers/net/eepro100.c driver.

Quoted 8 lines
Quoted 3 lines

Is there any known problem in e100 still preventing us from removing this driver (it seems noone was able anymore to verify the ARM problem)?

I think I am recalling some problems on ppc82xx, when e100 was stuck on startup, and eepro100 worked just fine.

Even if the patch below will be scheduled for application, we need to set up enough time
for approval that e100 will be fine for all the up-to-date hw; or it should be fixed/updated before eepro100 removal.

How/When can you/someone else test this?

Do the e100 maintainers (Cc'ed) know about such problems and their status?

Quoted 2 lines

Sincerely,
Vitaly

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#6 lore raw
In reply to Stephen Hemminger
Quoted 18 lines · Stephen Hemminger
Quoted 15 lines · On Sun, 15 Jan 2006 16:19:58 +0300 Vitaly Bordug <[email protected]> wrote:
Quoted 5 lines · On Thu, 5 Jan 2006 19:18:26 +0100 Adrian Bunk <[email protected]> wrote:

This patch removes the obsolete drivers/net/eepro100.c driver.

Is there any known problem in e100 still preventing us from removing this driver (it seems noone was able anymore to verify the ARM problem)?

I think I am recalling some problems on ppc82xx, when e100 was stuck on startup, and eepro100 worked just fine.

Even if the patch below will be scheduled for application, we need to set up enough time
for approval that e100 will be fine for all the up-to-date hw; or it should be fixed/updated before eepro100 removal.

Quoted 1 line
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

How about doing what was done with devfs removal, and remove it from the config menu system for a couple of releases.

IMHO the devfs case was different since the complete devfs removal patch (although being straightforward) touches many files.

In the eepro100 case (assuming there were no more known regressions in the e100 driver), reverting the removal patch would be trivial.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#7 lore raw

We don't of any problems reported against e100 that have not been talked about in this thread (in old ARCH types). I think the eepro100 driver should be removed from the config "just in case" but we are in full support of the e100 driver and if somebody says that it's not working on one of the different ARCHs we are willing to work with them to get it fixed. The problem is that we don't have all these different ARCH systems around to test against.

Another thing is that removal of the driver (or disabling the config) will hopefully force the issue in that people with these ARCHs will use the e100 and if they have problems we can get them fixed in the e100 driver. At this point nobody seems to be able to define a "real" problem other than talking about it.

--
Cheers,
John

#8 lore raw
Quoted 5 lines · John Ronciak

Another thing is that removal of the driver (or disabling the config) will hopefully force the issue in that people with these ARCHs will use the e100 and if they have problems we can get them fixed in the e100 driver. At this point nobody seems to be able to define a "real" problem other than talking about it.

I vote for eepro100 to come out.

Signature · 2 lines
John W. Linville
[email protected]
#9 lore raw
Quoted 8 lines · John W. Linville
Quoted 5 lines · John Ronciak

Another thing is that removal of the driver (or disabling the config) will hopefully force the issue in that people with these ARCHs will use the e100 and if they have problems we can get them fixed in the e100 driver. At this point nobody seems to be able to define a "real" problem other than talking about it.

Someone should send me a patch that adds eepro100 to the feature-removal doc.

jeff

#10 lore raw

PATCH 1/1 schedule eepro100.c for removal

Quoted 4 lines · Jeff Garzik
Quoted 3 lines · John W. Linville

On Tue, Jan 17, 2006 at 02:27:16PM -0800, John Ronciak wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines

Another thing is that removal of the driver (or disabling the config) will hopefully force the issue in that people with these ARCHs will use the e100 and if they have problems we can get them fixed in the e100 driver. At this point nobody seems to be able to define a "real" problem other than talking about it.

Someone should send me a patch that adds eepro100 to the feature-removal doc.

Patch below.

Quoted 1 line

jeff

cu
Adrian

<-- snip -->

Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +6 -0
@@ -164,0 +165,6 @@
+---------------------------
+
+What:   eepro100 network driver
+When:   April 2006
+Why:    replaced by the e100 driver
+Who:    Adrian Bunk <[email protected]>
#11 lore raw
In reply to John Ronciak
Quoted 8 lines · On Tue, 17 Jan 2006 14:27:16 -0800 John Ronciak <[email protected]> wrote:

We don't of any problems reported against e100 that have not been talked about in this thread (in old ARCH types). I think the eepro100 driver should be removed from the config "just in case" but we are in full support of the e100 driver and if somebody says that it's not working on one of the different ARCHs we are willing to work with them to get it fixed. The problem is that we don't have all these different ARCH systems around to test against.

Quoted 5 lines

Another thing is that removal of the driver (or disabling the config) will hopefully force the issue in that people with these ARCHs will use the e100 and if they have problems we can get them fixed in the e100 driver. At this point nobody seems to be able to define a "real" problem other than talking about it.

Ok then, let's go ahead, but
I vote for config exclusion as a first step,
so if anybody will run into problems, will use old mature stuff until e100 get fixed.

Due to rollback the removed driver - back and forth in killing/resurrecting stuff is not a good example to follow within the kernel.

Generally speaking, e100 should replace eepro*, but I can see no reason for rush in doing that one-step.

Signature · 2 lines
Sincerely, 
Vitaly