Skip to contentSkip to conversation

ptrace denies access to EFLAGS_RF

DISCUSSION Chuck Ebbert 2 participants 3 messages Jan 6, 2006 ptrace support

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 9 lines · Stephane Eranian

I am trying to the user HW debug registers on i386
and I am running into a problem with ptrace() not allowing access to EFLAGS_RF for POKEUSER (see FLAG_MASK).

I am not sure I understand the motivation for denying access to this flag which can be used to resume after a code breakpoint has been reached. It avoids the need to remove the breakpoint, single step, and reinstall. The equivalent functionality exists on IA-64 and is allowed by ptrace().

I see no reason for denying this. This patch should fix it:

i386: PTRACE_POKEUSR: allow changing RF bit in EFLAGS register.

Setting RF (resume flag) allows a debugger to resume execution after a code breakpoint without tripping the breakpoint again. It is reset by the CPU after execution of one instruction.

arch/i386/kernel/ptrace.c +6 -3
@@ -32,9 +32,12 @@
  * in exit.c or in signal.c.
  */
 
-/* determines which flags the user has access to. */
-/* 1 = access 0 = no access */
-#define FLAG_MASK 0x00044dd5
+/*
+ * Determines which flags the user has access to [1 = access, 0 = no access].
+ * Prohibits changing ID(21), VIP(20), VIF(19), VM(17), IOPL(12-13), IF(9).
+ * Also masks reserved bits (31-22, 15, 5, 3, 1).
+ */
+#define FLAG_MASK 0x00054dd5
 
 /* set's the trap flag. */
 #define TRAP_FLAG 0x100
Signature · 2 lines
Chuck
Currently reading: _Thud!_ by Terry Pratchett
#1 lore raw

Chuck,

Thanks for the quick patch. It does fix my problem.

Note that the same problem exists on x86_64 and the same patch should fix the problem there as well.

Quoted 46 lines · Chuck Ebbert

In-Reply-To: <[email protected]>

Quoted 9 lines · Stephane Eranian

I am trying to the user HW debug registers on i386
and I am running into a problem with ptrace() not allowing access to EFLAGS_RF for POKEUSER (see FLAG_MASK).

I am not sure I understand the motivation for denying access to this flag which can be used to resume after a code breakpoint has been reached. It avoids the need to remove the breakpoint, single step, and reinstall. The equivalent functionality exists on IA-64 and is allowed by ptrace().

I see no reason for denying this. This patch should fix it:

i386: PTRACE_POKEUSR: allow changing RF bit in EFLAGS register.

Setting RF (resume flag) allows a debugger to resume execution after a code breakpoint without tripping the breakpoint again. It is reset by the CPU after execution of one instruction.

arch/i386/kernel/ptrace.c +6 -3
@@ -32,9 +32,12 @@
  * in exit.c or in signal.c.
  */
 
-/* determines which flags the user has access to. */
-/* 1 = access 0 = no access */
-#define FLAG_MASK 0x00044dd5
+/*
+ * Determines which flags the user has access to [1 = access, 0 = no access].
+ * Prohibits changing ID(21), VIP(20), VIF(19), VM(17), IOPL(12-13), IF(9).
+ * Also masks reserved bits (31-22, 15, 5, 3, 1).
+ */
+#define FLAG_MASK 0x00054dd5
 
 /* set's the trap flag. */
 #define TRAP_FLAG 0x100
Signature · 2 lines
Chuck
Currently reading: _Thud!_ by Terry Pratchett
Signature · 1 line
-Stephane
#2 lore raw
In reply to Chuck Ebbert

Chuck,

To my surprise, applying the same fix to the x86_64 does not solve the problem on my Opteron box. I verified that the offset (144) matches with what the kernel is expecting. Somehow the RF is lost or not set in the proper location. I cannot make forward progress once I reach the breakpoint.

Is there something else to on x86_64?

Thanks.

Quoted 46 lines · Chuck Ebbert

In-Reply-To: <[email protected]>

Quoted 9 lines · Stephane Eranian

I am trying to the user HW debug registers on i386
and I am running into a problem with ptrace() not allowing access to EFLAGS_RF for POKEUSER (see FLAG_MASK).

I am not sure I understand the motivation for denying access to this flag which can be used to resume after a code breakpoint has been reached. It avoids the need to remove the breakpoint, single step, and reinstall. The equivalent functionality exists on IA-64 and is allowed by ptrace().

I see no reason for denying this. This patch should fix it:

i386: PTRACE_POKEUSR: allow changing RF bit in EFLAGS register.

Setting RF (resume flag) allows a debugger to resume execution after a code breakpoint without tripping the breakpoint again. It is reset by the CPU after execution of one instruction.

arch/i386/kernel/ptrace.c +6 -3
@@ -32,9 +32,12 @@
  * in exit.c or in signal.c.
  */
 
-/* determines which flags the user has access to. */
-/* 1 = access 0 = no access */
-#define FLAG_MASK 0x00044dd5
+/*
+ * Determines which flags the user has access to [1 = access, 0 = no access].
+ * Prohibits changing ID(21), VIP(20), VIF(19), VM(17), IOPL(12-13), IF(9).
+ * Also masks reserved bits (31-22, 15, 5, 3, 1).
+ */
+#define FLAG_MASK 0x00054dd5
 
 /* set's the trap flag. */
 #define TRAP_FLAG 0x100
Signature · 2 lines
Chuck
Currently reading: _Thud!_ by Terry Pratchett
Signature · 1 line
-Stephane