2.6.15 cfq oops
Subsystems (2)
Looks like some nice slab poison...
Dave
Oops: 0000 [#1]
last sysfs file:
/devices/pci0000:00/0000:00:1d.7/usb1/1-0:1.0/bAlternateSettingModules linked
in: usb_storage ata_piix libata e1000 ohci1394 ieee1394 uhci_hcdsCPU: 0
EIP: 0060:[<c01c312e>] Not tainted VLI
EFLAGS: 00010002 (2.6.15-1.1819_FC5)
EIP is at rb_next+0x9/0x22
eax: 6b6b6b6b ebx: dfed01f8 ecx: c01bf65a edx: 6b6b6b6b
esi: c1991e98 edi: 00000202 ebp: dfed403c esp: c03c1f14
ds: 007b es: 007b ss: 0068
Process swapper (pid: 0, threadinfo=c03c1000 task=c0327ba0)
Stack: c01bf662 c01b5dfa dfed01f8 c01b85dc c040c284 00000004 c1991e98 c023c8ab
c1991e98 00000000 c040c284 00000000 c023d3a4 000194d0 00000000 dfed403c
c1991e98 c040c284 c1991e98 00000000 c0231f2d 000194d0 00000000 000194d0
Call Trace:
[<c01bf662>] cfq_latter_request+0x8/0x14 [<c01b5dfa>] elv_latter_request+07
[<c01b85dc>] blk_attempt_remerge+0x1d/0x3c [<c023c8ab>] cdrom_start_read+0e
[<c023d3a4>] ide_do_rw_cdrom+0xdd/0x14a [<c0231f2d>] start_request+0x1b1/01
[<c023220f>] ide_do_request+0x2a0/0x2fb [<c023265e>] ide_intr+0xf3/0x11b
[<c023c1a7>] cdrom_read_intr+0x0/0x2a1 [<c013632a>] handle_IRQ_event+0x23/c
[<c01363cd>] __do_IRQ+0x7a/0xcd [<c01054d0>] do_IRQ+0x5c/0x77
=======================
[<c0103cea>] common_interrupt+0x1a/0x20 [<c0101120>] mwait_idle+0x1a/0x2e
[<c01010a3>] cpu_idle+0x38/0x4d [<c0390635>] start_kernel+0x17a/0x17c
Code: 85 c0 74 0b 8b 50 0c 85 d2 74 04 89 d0 eb f5 c3 8b 00 85 c0 74 0b 8b 50 0Quoted 15 lines · Dave Jones
Looks like some nice slab poison...
Dave
Oops: 0000 [#1]last sysfs file:
/devices/pci0000:00/0000:00:1d.7/usb1/1-0:1.0/bAlternateSettingModules linked
in:usb_storageata_piixlibata e1000 ohci1394 ieee1394uhci_hcdsCPU: 0
EIP: 0060:[<c01c312e>] Not tainted VLI
EFLAGS: 00010002 (2.6.15-1.1819_FC5)
EIP is atrb_next+0x9/0x22
eax:6b6b6b6bebx:dfed01f8ecx:c01bf65aedx:6b6b6b6b
esi:c1991e98edi: 00000202 ebp:dfed403cesp:c03c1f14
ds: 007b es: 007b ss: 0068
Process swapper (pid: 0, threadinfo=c03c1000 task=c0327ba0)
Quoted 14 lines
Stack: c01bf662 c01b5dfa dfed01f8 c01b85dc c040c284 00000004 c1991e98 c023c8ab
c1991e98 00000000 c040c284 00000000 c023d3a4 000194d0 00000000 dfed403c
c1991e98 c040c284 c1991e98 00000000 c0231f2d 000194d0 00000000 000194d0
Call Trace:
[<c01bf662>] cfq_latter_request+0x8/0x14 [<c01b5dfa>] elv_latter_request+07
[<c01b85dc>] blk_attempt_remerge+0x1d/0x3c [<c023c8ab>] cdrom_start_read+0e
[<c023d3a4>] ide_do_rw_cdrom+0xdd/0x14a [<c0231f2d>] start_request+0x1b1/01
[<c023220f>] ide_do_request+0x2a0/0x2fb [<c023265e>] ide_intr+0xf3/0x11b
[<c023c1a7>] cdrom_read_intr+0x0/0x2a1 [<c013632a>] handle_IRQ_event+0x23/c
[<c01363cd>] __do_IRQ+0x7a/0xcd [<c01054d0>] do_IRQ+0x5c/0x77
=======================
[<c0103cea>] common_interrupt+0x1a/0x20 [<c0101120>] mwait_idle+0x1a/0x2e
[<c01010a3>] cpu_idle+0x38/0x4d [<c0390635>] start_kernel+0x17a/0x17c
Code: 85 c0 74 0b 8b 50 0c 85 d2 74 04 89 d0 eb f5 c3 8b 00 85 c0 74 0b 8b 50 0The blk_attempt_remerge() is a bad interface to be honest, and it's hard to get to work reliably because it's done too late. I think the best option is just to kill it, this will cause problems with other io schedulers as well.
I've merged this up for 2.6.16-rc inclusion, probably should go to stabel as well.
---
[PATCH] Kill blk_attempt_remerge()
It's a bad interface, and it's always done too late. Remove it.
block/ll_rw_blk.c +0 -24
@@ -2748,30 +2748,6 @@ static inline int attempt_front_merge(rereturn 0 ; } -/** -* blk_attempt_remerge - attempt to remerge active head with next request -* @q: The &request_queue_t belonging to the device -* @rq: The head request (usually) -* -* Description: -* For head-active devices, the queue can easily be unplugged so quickly -* that proper merging is not done on the front request. This may hurt -* performance greatly for some devices. The block layer cannot safely -* do merging on that first request for these queues, but the driver can -* call this function and make it happen any way. Only the driver knows -* when it is safe to do so. -**/ -void blk_attempt_remerge (request_queue_t *q,struct request *rq) -{ -unsigned long flags; - -spin_lock_irqsave (q->queue_lock, flags); -attempt_back_merge (q, rq); -spin_unlock_irqrestore (q->queue_lock, flags); -} - -EXPORT_SYMBOL (blk_attempt_remerge); -static void init_request_from_bio (struct request *req,struct bio *bio) { req->flags |=REQ_CMD ;
drivers/cdrom/cdrom.c +1 -1
@@ -426,7 +426,7 @@ int register_cdrom(struct cdrom_device_i cdi->exit = cdrom_mrw_exit;if (cdi->disk) - cdi->cdda_method =CDDA_BPC_FULL ; + cdi->cdda_method =CDDA_BPC_SINGLE ;else cdi->cdda_method =CDDA_OLD ;
drivers/ide/ide-cd.c +0 -10
@@ -1332,8 +1332,6 @@ static ide_startstop_t cdrom_start_readif (cdrom_read_from_buffer (drive))return ide_stopped; -blk_attempt_remerge (drive->queue, rq); -/* Clear the local sector buffer. */ info->nsectors_buffered =0 ;
@@ -1874,14 +1872,6 @@ static ide_startstop_t cdrom_start_writereturn ide_stopped; } -/* -* for dvd-ram and such media, it's a really big deal to get -* big writes all the time. so scour the queue and attempt to -* remerge requests, often the plugging will not have had time -* to do this properly -*/ -blk_attempt_remerge (drive->queue, rq); - info->nsectors_buffered =0 ;/* use dma, if possible. we don't need to check more, since we
include/linux/blkdev.h +0 -1
@@ -595,7 +595,6 @@ extern void generic_make_request(structextern void blk_put_request (struct request *);extern void __blk_put_request (request_queue_t *,struct request *);extern void blk_end_sync_rq (struct request *rq,int error); -extern void blk_attempt_remerge (request_queue_t *,struct request *);extern struct request *blk_get_request (request_queue_t *,int ,gfp_t );extern void blk_insert_request (request_queue_t *,struct request *,int ,void *);extern void blk_requeue_request (request_queue_t *,struct request *);
Signature · 1 line
Jens Axboe
On Mon, 9 Jan 2006 11:58:01 +0100 Jens Axboe wrote:
[skip]
Quoted 11 lines
I've merged this up for 2.6.16-rc inclusion, probably should go to stabel as well.
---
[PATCH] Kill
blk_attempt_remerge()It's a bad interface, and it's always done too late. Remove it.
Signed-off-by Jens Axboe <[email protected]>
[skip]
drivers/cdrom/cdrom.c int register_cdrom(struct cdrom_device_i · line 431
Quoted 12 lines
drivers/cdrom/cdrom.c +1
-1@@ -426,7 +426,7 @@ int register_cdrom(struct cdrom_device_i cdi->exit = cdrom_mrw_exit;if (cdi->disk) - cdi->cdda_method =CDDA_BPC_FULL ; + cdi->cdda_method =CDDA_BPC_SINGLE ;else cdi->cdda_method =CDDA_OLD ;
Does not seem to be related to the rest of patch...
[skip]
Quoted 22 lines · Sergey Vlasov
On Mon, 9 Jan 2006 11:58:01 +0100 Jens Axboe wrote:
[skip]
Quoted 11 lines
I've merged this up for 2.6.16-rc inclusion, probably should go to stabel as well.
---
[PATCH] Kill
blk_attempt_remerge()It's a bad interface, and it's always done too late. Remove it.
Signed-off-by Jens Axboe <[email protected]>[skip]
Quoted 7 lines
drivers/cdrom/cdrom.c +0
-0@@ -426,7 +426,7 @@ int register_cdrom(struct cdrom_device_i cdi->exit = cdrom_mrw_exit;
Quoted 7 lines
drivers/cdrom/cdrom.c int register_cdrom(struct cdrom_device_i · line 431
Quoted 5 lines
drivers/cdrom/cdrom.c +1
-1if (cdi->disk) - cdi->cdda_method =CDDA_BPC_FULL ; + cdi->cdda_method =CDDA_BPC_SINGLE ;else cdi->cdda_method =CDDA_OLD ;Does not seem to be related to the rest of patch...
Indeed, dirty git tree...
Signature · 1 line
Jens Axboe