Skip to contentSkip to conversation

2.6-git: BITS_PER_LONG

DISCUSSION Russell King 2 participants 3 messages Jan 7, 2006 – Jan 9, 2006

lore
Share & tools
lore
#0 lore raw

Hi.

With the latest git, I'm seeing a number of:

include/asm-generic/atomic.h:20:5: warning: "BITS_PER_LONG" is not defined

What's intended here? Should asm-generic/atomic.h include asm/types.h?

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
#1 lore raw
Quoted 7 lines · Russell King

Hi.

With the latest git, I'm seeing a number of:

include/asm-generic/atomic.h:20:5: warning: "BITS_PER_LONG" is not defined

What's intended here? Should asm-generic/atomic.h include asm/types.h?

asm/types.h should be included by asm/atomic.h. Which arch is this?

#2 lore raw
Quoted 8 lines · Christoph Lameter
Quoted 5 lines · Russell King

With the latest git, I'm seeing a number of:

include/asm-generic/atomic.h:20:5: warning: "BITS_PER_LONG" is not defined

What's intended here? Should asm-generic/atomic.h include asm/types.h?

asm/types.h should be included by asm/atomic.h.

Disagree - nothing in asm/atomic.h needs asm/types.h. If asm-generic/atomic.h has this requirement, it should be the one including asm/types.h (or should it be linux/types.h ?)

Quoted 1 line

Which arch is this?

ARM.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core