Skip to contentSkip to conversation

SOFTWARE_SUSPEND: dependency on non-existing FVR symbol

PATCH Applied Adrian Bunk 2 participants 5 messages Jan 6, 2006 – Jan 14, 2006

Subsystems (2)
lore
Share & tools
lore
#1 lore raw
In reply to Adrian Bunk
Quoted 11 lines · Adrian Bunk

The following issue in kernel/power/Kconfig was noted by Jean-Luc Leger <[email protected]>:

config SOFTWARE_SUSPEND
bool "Software Suspend"
depends on PM && SWAP && (X86 && (!SMP || SUSPEND_SMP)) || ((FVR || PPC32) && !SMP)

The problem is that there is no FVR symbol in the kernel.

Is this a misspelling of FRV or something different?

FRV, IIRC, but apparently noone ever tested that.
Pavel

Signature · 1 line
Thanks, Sharp!
#0 lore raw

The following issue in kernel/power/Kconfig was noted by Jean-Luc Leger <[email protected]>:

config SOFTWARE_SUSPEND
bool "Software Suspend"
depends on PM && SWAP && (X86 && (!SMP || SUSPEND_SMP)) || ((FVR || PPC32) && !SMP)

The problem is that there is no FVR symbol in the kernel.

Is this a misspelling of FRV or something different?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
In reply to Pavel Machek
Quoted 9 lines · Pavel Machek
Quoted 8 lines · Adrian Bunk

The following issue in kernel/power/Kconfig was noted by Jean-Luc Leger <[email protected]>:

config SOFTWARE_SUSPEND
bool "Software Suspend"
depends on PM && SWAP && (X86 && (!SMP || SUSPEND_SMP)) || ((FVR || PPC32) && !SMP)

Quoted 5 lines
Quoted 3 lines

The problem is that there is no FVR symbol in the kernel.

Is this a misspelling of FRV or something different?

FRV, IIRC, but apparently noone ever tested that.

Should my patch remove or rename it to FRV?

Quoted 1 line

Pavel

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw

PATCH 1/1 SOFTWARE_SUSPEND: fix a typo in the dependencies

In reply to Pavel Machek

This patch fixes a typo in the dependencies of SOFTWARE_SUSPEND.

This patch is based on a report by
Jean-Luc Leger <[email protected]>.

kernel/power/Kconfig renamed from kernel/power/Kconfig.old +1 -1
@@ -38,7 +38,7 @@
 
 config SOFTWARE_SUSPEND
 	bool "Software Suspend"
-	depends on PM && SWAP && (X86 && (!SMP || SUSPEND_SMP)) || ((FVR || PPC32) && !SMP)
+	depends on PM && SWAP && (X86 && (!SMP || SUSPEND_SMP)) || ((FRV || PPC32) && !SMP)
 	---help---
 	  Enable the possibility of suspending the machine.
 	  It doesn't need APM.
Applied
#4 lore raw

Re: [2.6 patch] SOFTWARE_SUSPEND: fix a typo in the dependencies

Quoted 4 lines · Adrian Bunk

This patch fixes a typo in the dependencies of SOFTWARE_SUSPEND.

This patch is based on a report by
Jean-Luc Leger <[email protected]>.

Applied to my tree, but feel free to push it yourself. It will take me a while to sync.
Pavel

Signature · 1 line
Thanks, Sharp!