Skip to contentSkip to conversation

arch/parisc/Makefile: remove GCC_VERSION

PATCH In review Adrian Bunk 3 participants 5 messages Jan 12, 2006 PA-RISC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/parisc/Makefile: remove GCC_VERSION

This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.

arch/parisc/Makefile renamed from arch/parisc/Makefile.old +2 -6
@@ -35,12 +35,8 @@
 
 OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
 
-GCC_VERSION     := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)).  GCC v3.3 or above is required.)
+ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
+$(error Sorry, your compiler is too old.  GCC v3.3 or above is required.)
 endif
 
 cflags-y	:= -pipe
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Adrian Bunk

This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.

I assume the parisc people will take this one.

Sam

Quoted 24 lines
arch/parisc/Makefile renamed from arch/parisc/Makefile.old +2 -7
@@ -35,12 +35,8 @@
 
 OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
 
-GCC_VERSION     := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)).  GCC v3.3 or above is required.)
+ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
+$(error Sorry, your compiler is too old.  GCC v3.3 or above is required.)
 endif
 
 cflags-y	:= -pipe
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 2 lines · Sam Ravnborg

I assume the parisc people will take this one.

I'm confused... you didn't mention at all what the benefit or reason for this is in your changelog entry...

Cheers,
Kyle

#3 lore raw
Quoted 6 lines · Kyle McMartin
Quoted 2 lines · Sam Ravnborg

I assume the parisc people will take this one.

I'm confused... you didn't mention at all what the benefit or reason for this is in your changelog entry...

In -mm a patch appeared that took for granted that GCC_VERSION was set. So it seems that people started to think that GCC_VERSION was part of the kbuild PAI and realibale. The best way to avoid this confusion was to kill GCC_VERSION alltogether.

Andrew & I did it in most cases, and Adrian cleaned up parisc and killed the last instance og GCC_VERSION there.

No functional changes, but a nice cleanup.

Sam

#4 lore raw
Quoted 5 lines · Sam Ravnborg

Andrew & I did it in most cases, and Adrian cleaned up parisc and killed the last instance og GCC_VERSION there.

No functional changes, but a nice cleanup.

OK. Ack that, then, I'll merge it in my tree.

Cheers,
Kyle