Skip to contentSkip to conversation

Problem with the cfi flash driver with a x8/x16 flash configuredin x8 mode.

U-Boot-Users Alex BASTOS 3 participants 3 messages Jan 12, 2006 – Feb 28, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Txema,

Quoted 7 lines

Does anybody test the cfi flash driver (cfi_flash.c) with a x8/x16 flash configured in x8 mode ? I'm trying to port U-Boot for a Lite5200B with a S29GL128N flash (CFI compliant) using the cfi flash driver. U-Boot detects the flash correctly but It's unable to erase or write the flash. In my case the following patch fix the bug but I'm not completly sure If It's only a bug with my configuration. Any suggestions? Could anybody test the patch in other architecture?

I think your topic is very similar to this recent one:

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/19970

and previous similar patches have been submited and are still pending (but it seems they are coming, read the whole thread)

So, yes, til now cfi_flash didn't support x8 mode for AMD chips, but it will.

Best regards,

Alex BASTOS

#2 lore raw

[U-Boot-Users] Re: Problem with the cfi flash driver with a x8/x16 flash configuredinx8 mode.

Alex BASTOS wrote:

Thanks Alex,

Quoted 14 lines

Txema,

Quoted 9 lines

Does anybody test the cfi flash driver (cfi_flash.c) with a x8/x16 flash configured in x8 mode ? I'm trying to port U-Boot for a Lite5200B with a S29GL128N flash (CFI compliant) using the cfi flash driver. U-Boot detects the flash correctly but It's unable to erase or write the flash. In my case the following patch fix the bug but I'm not completly sure If It's only a bug with my configuration. Any suggestions? Could anybody test the patch in other architecture?

Quoted 5 lines

I think your topic is very similar to this recent one:

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/19970

OK, I've checked it.

Quoted 4 lines

and previous similar patches have been submited and are still pending (but it seems they are coming, read the whole thread)

But not the patch that Wolfgang proposed, isn'it?

Quoted 12 lines

So, yes, til now cfi_flash didn't support x8 mode for AMD chips, but it will.

Best regards,

Alex BASTOS

I think the patch that Wolfgang proposed could be like that. I've tested it with a S29GL128N x8/x16 in x8 mode. It works fine. But I have no idea what would happen in x16 mode or others modes. I haven't the hardware to check it.

cfi_flash.c 2006-01-12 17:21:19.000000000 +0100 renamed from tmp/u-boot/drivers/cfi_flash.c 2006-01-12 12:22:08.000000000 +0100 +4 -3
@@ -107,9 +107,10 @@
 
 #define AMD_STATUS_TOGGLE              0x40
 #define AMD_STATUS_ERROR               0x20
-#define AMD_ADDR_ERASE_START           0x555
-#define AMD_ADDR_START                 0x555
-#define AMD_ADDR_ACK                   0x2AA
+
+#define AMD_ADDR_ERASE_START           (0xAAA >> (info->portwidth-1))
+#define AMD_ADDR_START                 (0xAAA >> (info->portwidth-1))
+#define AMD_ADDR_ACK                   (0x555 >> (info->portwidth-1))
 
 #define FLASH_OFFSET_CFI               0x55
 #define FLASH_OFFSET_CFI_RESP          0x10

Best regards,
Jose Maria Lopez.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tlopez.vcf
Type: text/x-vcard
Size: 427 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060112/2e17762a/attachment.vcf

#3 lore raw

[U-Boot-Users] Re: Problem with the cfi flash driver with a x8/x16 flash configuredinx8 mode.

cfi_flash.c 2006-01-12 17:21:19.000000000 +0100

Quoted 8 lines · In message <[email protected]> you wrote:

I think the patch that Wolfgang proposed could be like that. I've tested it with a S29GL128N x8/x16 in x8 mode. It works fine. But I have no idea what would happen in x16 mode or others modes. I haven't the hardware to check it.

cfi_flash.c 2006-01-12 17:21:19.000000000 +0100 renamed from tmp/u-boot/drivers/cfi_flash.c 2006-01-12 12:22:08.000000000 +0100 +0 -0

Not used. Version from Txema Lopez <[email protected]> from 16. 01. 2006 applied instead. Closed. Thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Emotions are alien to me.  I'm a scientist.
	-- Spock, "This Side of Paradise", stardate 3417.3