Skip to contentSkip to conversation

Do not inherit properties for the quota inodes from the root inode.

XFS Chris Wedgwood 2 participants 2 messages Jan 12, 2006 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 6 lines · Linux Kernel Mailing List

tree 589ad79019067e1b82006bacf6c10d1d717a46dc
parent 4ef19dddbaf2f24e492c18112fd8a04ce116daca
author Nathan Scott <[email protected]> Wed, 11 Jan 2006 15:27:50 +1100 committer Nathan Scott <[email protected]> Wed, 11 Jan 2006 15:27:50 +1100

[XFS] Do not inherit properties for the quota inodes from the root inode.

lots of whitespace changes... :)

Review

Quoted 6 lines
(quoted diff) +1 -1
-	if ((error = xfs_dir_ialloc(&tp, mp->m_rootip, S_IFREG, 1, 0,
+	if ((error = xfs_dir_ialloc(&tp, &zeroino, S_IFREG, 1, 0,
 				   &zerocr, 0, 1, ip, &committed))) {
 		xfs_trans_cancel(tp, XFS_TRANS_RELEASE_LOG_RES |
 				 XFS_TRANS_ABORT);

why would you want to do this at all?

#2 lore raw

Hi Chris,

Quoted 3 lines · Chris Wedgwood
Quoted 1 line

[XFS] Do not inherit properties for the quota inodes from the root inode.

lots of whitespace changes... :)

If by "lots" you mean "one line", then yes!

Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +1 -1
-	if ((error = xfs_dir_ialloc(&tp, mp->m_rootip, S_IFREG, 1, 0,
+	if ((error = xfs_dir_ialloc(&tp, &zeroino, S_IFREG, 1, 0,
 				   &zerocr, 0, 1, ip, &committed))) {
 		xfs_trans_cancel(tp, XFS_TRANS_RELEASE_LOG_RES |
 				 XFS_TRANS_ABORT);

why would you want to do this at all?

I'm not sure what you're asking? There are things we do not want to inherit from the root inode (certain inode flags in particular) when the quota inodes are being created... does that help?

cheers.

Signature · 1 line
Nathan