Skip to contentSkip to conversation

PROBLEM: Oops in Kernel 2.6.15 usbhid

DISCUSSION Chuck Ebbert 2 participants 2 messages Jan 13, 2006 USB

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 20 lines · Adrian Bunk
Quoted 19 lines · Dmitry Torokhov
Quoted 18 lines · Patrick Read

drivers/usb/input/pid.c static int hid_pid_upload_effect(struct · line 265

Quoted 13 lines · Dmitry Torokhov

===================================================================

drivers/usb/input/pid.c +1 -1
@@ -259,7 +259,7 @@ static int hid_pid_upload_effect(struct
 int hid_pid_init(struct hid_device *hid)
 {
        struct hid_ff_pid *private;
-       struct hid_input *hidinput = list_entry(&hid->inputs, struct hid_input, list);
+       struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
        struct input_dev *input_dev = hidinput->input;
 
        private = hid->ff_private = kzalloc(sizeof(struct hid_ff_pid), GFP_KERNEL);

The above fix works like a charm. 2.6.15 is running on this very computer that I'm typing on.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Thank you for your good work. Please ensure that this fix gets incorporated in the mainline kernel.

Thank you for testing it, I will forward it to Linus.

Could you also forward it [email protected] for inclusion in 2.6.15.x?

I don't see it in Linus's tree yet.

Could it still be put into 2.6.15.1?

--

From: Dmitry Torokhov <[email protected]>

Fix oops in usbhid.

drivers/usb/input/pid.c +1 -1
@@ -259,7 +259,7 @@ static int hid_pid_upload_effect(struct 
 int hid_pid_init(struct hid_device *hid)
 {
 	struct hid_ff_pid *private;
-	struct hid_input *hidinput = list_entry(&hid->inputs, struct hid_input, list);
+	struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
 	struct input_dev *input_dev = hidinput->input;
 
 	private = hid->ff_private = kzalloc(sizeof(struct hid_ff_pid), GFP_KERNEL);
Signature · 2 lines
Chuck
Currently reading: _Olympos_ by Dan Simmons
#1 lore raw
Quoted 3 lines · * Chuck Ebbert ([email protected]) wrote:

I don't see it in Linus's tree yet.

Could it still be put into 2.6.15.1?

I'd rather queue it to 2.6.15.2.
-chris