Skip to contentSkip to conversation

EDAC config cleanup

PATCH Dave Jones 3 participants 5 messages Jan 19, 2006 EDAC-core

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

The AMD76x chipsets aren't used in 64-bit, so don't offer the driver to the user.

drivers/edac/Kconfig renamed from drivers/edac/Kconfig~ +1 -1
@@ -46,7 +46,7 @@ config EDAC_MM_EDAC
 
 config EDAC_AMD76X
 	tristate "AMD 76x (760, 762, 768)"
-	depends on EDAC_MM_EDAC  && PCI
+	depends on EDAC_MM_EDAC && PCI X86_32
 	help
 	  Support for error detection and correction on the AMD 76x
 	  series of chipsets used with the Athlon processor.
#1 lore raw

drivers/edac/Kconfig config EDAC_MM_EDAC · line 49

Quoted 13 lines · Dave Jones

The AMD76x chipsets aren't used in 64-bit, so don't offer the driver to the user.

drivers/edac/Kconfig renamed from drivers/edac/Kconfig~ +1 -1
@@ -46,7 +46,7 @@ config EDAC_MM_EDAC
 
 config EDAC_AMD76X
 	tristate "AMD 76x (760, 762, 768)"
-	depends on EDAC_MM_EDAC  && PCI
+	depends on EDAC_MM_EDAC && PCI X86_32
                                      ^ && ???
Quoted 4 lines
drivers/edac/Kconfig renamed from drivers/edac/Kconfig~ +0 -1
 	help
 	  Support for error detection and correction on the AMD 76x
 	  series of chipsets used with the Athlon processor.
-
Signature · 1 line
~Randy
author
#2 lore raw
Quoted 2 lines · Randy.Dunlap

Review

Quoted 1 line
(quoted diff) +1 -0
+	depends on EDAC_MM_EDAC && PCI X86_32
                                      ^ && ???

Gah. Of course. (That'll teach me to not test 'obvious' patches :) Here it is again, unborked. (tested with make ARCH=x86_64 menuconfig)

The AMD76x chipsets aren't used in 64-bit, so don't offer the driver to the user.

drivers/edac/Kconfig renamed from drivers/edac/Kconfig~ +1 -1
@@ -46,7 +46,7 @@ config EDAC_MM_EDAC
 
 config EDAC_AMD76X
 	tristate "AMD 76x (760, 762, 768)"
-	depends on EDAC_MM_EDAC  && PCI
+	depends on EDAC_MM_EDAC && PCI && X86_32
 	help
 	  Support for error detection and correction on the AMD 76x
 	  series of chipsets used with the Athlon processor.
#4 lore raw
In reply to Dave Jones

drivers/edac/Kconfig config EDAC_MM_EDAC · line 49

Quoted 2 lines · Dave Jones
drivers/edac/Kconfig renamed from drivers/edac/Kconfig~ +1 -1
-	depends on EDAC_MM_EDAC  && PCI
+	depends on EDAC_MM_EDAC && PCI X86_32

NAK add another &&