Skip to contentSkip to conversation

IPW2100 fails to load firmware when booting on battery

PATCH In review Olaf Hering 2 participants 2 messages Jan 21, 2006 – Jan 22, 2006 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IPW2100 fails to load firmware when booting on battery

We carry this patch around since a while. Is it safe to increase the timeout also in mainline?

References: https://bugzilla.novell.com/show_bug.cgi?id=74526

IPW2100 fails to load firmware when booting on battery; increasing the timeout solves the problem.

drivers/base/firmware_class.c +1 -1
diff -urNp linux-2.6.12/drivers/base/firmware_class.c linux-2.6.12.SUSE/drivers/base/firmware_class.c
@@ -30,7 +30,7 @@ enum {
 	FW_STATUS_READY,
 };
 
-static int loading_timeout = 10;	/* In seconds */
+static int loading_timeout = 30;	/* In seconds */
 
 /* fw_lock could be moved to 'struct firmware_priv' but since it is just
  * guarding for corner cases a global lock should be OK */
Signature · 2 lines
short story of a lazy sysadmin:
 alias appserv=wotan
#1 lore raw
Quoted 7 lines · Olaf Hering

We carry this patch around since a while. Is it safe to increase the timeout also in mainline?

References: https://bugzilla.novell.com/show_bug.cgi?id=74526

IPW2100 fails to load firmware when booting on battery; increasing the timeout solves the problem.

Not needed, can be adjusted from user space, once /sys is mounted. echo -n 30 >/sys/class/firmware/timeout

The firmware class driver just provides a sane default, nothing else.

If this becomes a very common case (many drivers having big firmware and userspace needs a lot of time providing it), your patch should go in. But then the _default_ is wrong for many users.

Regards

Ingo Oeser