Skip to contentSkip to conversation

i2c-omap: Fix i2c_xfer for 1 msg

PATCH In review Ladislav Michl 2 participants 4 messages Jan 24, 2006 – Feb 7, 2006

Subsystems (4)
I2C subsystem host drivers OMAP2+ support OMAP1 support OMAP I2C driver
lore
Share & tools
lore

Ladislav Michl

author
#0 lore raw

PATCH 1/2 i2c-omap: Fix i2c_xfer for 1 msg

omap_i2c_xfer is supposed to return number of messages successfuly transfered. Remove bogus condition which causes it to fail when transfering one message.

Signed-off-by Ladislav Michl <[email protected]>
drivers/i2c/busses/i2c-omap.c +1 -1
index fb41255..b021073 100644
@@ -403,7 +403,7 @@ omap_i2c_xfer(struct i2c_adapter *adap, 
 			break;
 	}
 
-	if (r == 0 && num > 1)
+	if (r == 0)
 		r = num;
 out:
 	omap_i2c_disable_clocks(dev);
author
#1 lore raw
Quoted 3 lines · Ladislav Michl

omap_i2c_xfer is supposed to return number of messages successfuly transfered. Remove bogus condition which causes it to fail when transfering one message.

Ping? Everyone happy with current state of art? :-)
Also could anyone with 15xx test second patch (2/2)? If there are no objectios I'd like to see both applied :-)

Thanks,
ladis

maintainer
#2 lore raw
Quoted 6 lines · Ladislav Michl
Quoted 3 lines · Ladislav Michl

omap_i2c_xfer is supposed to return number of messages successfuly transfered. Remove bogus condition which causes it to fail when transfering one message.

Ping? Everyone happy with current state of art? :-)

Everybody's just busy I'd assume...

Quoted 2 lines

Also could anyone with 15xx test second patch (2/2)? If there are no objectios I'd like to see both applied :-)

I'll push them on Friday unless somebody somebody files a complaint.

Tony

maintainer
#3 lore raw
Quoted 6 lines · Tony Lindgren
Quoted 5 lines · Ladislav Michl
Quoted 3 lines · Ladislav Michl

omap_i2c_xfer is supposed to return number of messages successfuly transfered. Remove bogus condition which causes it to fail when transfering one message.

Quoted 8 lines
Quoted 1 line

Ping? Everyone happy with current state of art? :-)

Everybody's just busy I'd assume...

Quoted 2 lines

Also could anyone with 15xx test second patch (2/2)? If there are no objectios I'd like to see both applied :-)

I'll push them on Friday unless somebody somebody files a complaint.

Just pushed them finally.

Tony