Skip to contentSkip to conversation

fix ia64_hint definition for intel compiler intrinsic

PATCH In review Chen, Kenneth W 3 participants 4 messages Jan 26, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix ia64_hint definition for intel compiler intrinsic

Map ia64_hint() to internal intel compiler intrinsic.

---
Compile tested on selective files. icc 9.0 appears to have memory clobber behavior for the hint@pause intrinsic similar to gcc with "memory" clobber modifier. Your mileage may vary.

include/asm-ia64/intel_intrin.h renamed from include/asm-ia64/intel_intrin.h.orig +2 -1
@@ -122,7 +122,8 @@ __s64 _m64_popcnt(__s64 a);
 #define ia64_getreg		__getReg
 #define ia64_setreg		__setReg
 
-#define ia64_hint(x)
+#define ia64_hint		__hint
+#define ia64_hint_pause		0
 
 #define ia64_mux1_brcst	 0
 #define ia64_mux1_mix		 8
#1 lore raw

include/asm-ia64/intel_intrin.h

Quoted 12 lines · Kenneth W

Map ia64_hint() to internal intel compiler intrinsic.

---
Compile tested on selective files. icc 9.0 appears to have memory clobber behavior for the hint@pause intrinsic similar to gcc with "memory" clobber modifier. Your mileage may vary.

include/asm-ia64/intel_intrin.h renamed from include/asm-ia64/intel_intrin.h.orig +0 -0

include/asm-ia64/intel_intrin.h should just include <ia64intrin.h>. Why not check out my patch:

http://marc.theaimsgroup.com/?l=linux-ia64&m3475932502202&w=2

H.J.

#2 lore raw
In reply to Chen, Kenneth W
Quoted 4 lines

include/asm-ia64/intel_intrin.h should just include <ia64intrin.h>. Why not check out my patch:

http://marc.theaimsgroup.com/?l=linux-ia64&m3475932502202&w=2

There are two patches attached to that message, the first deletes all contents from include/asm-ia64/intel_intrin.h. The second puts in the #include <ia64intrin.h> together with a bunch of Linux specific defines including:

+#define ia64_hint(x)

So I'd need Ken's patch on top of yours to make cpu_relax() actually do something, right?

The second patch also changed some sn2 specific code and didn't get an ack.

Overall, it would be interesting to get the ia64 kernel building and running on icc (if only to get the benefit of different warning/error checking in an alternate compiler).

-Tony

#3 lore raw
In reply to Chen, Kenneth W

Luck, Tony wrote on Thursday, January 26, 2006 10:55 AM

Quoted 9 lines

There are two patches attached to that message, the first deletes all contents from include/asm-ia64/intel_intrin.h. The second puts in the #include <ia64intrin.h> together with a bunch of Linux specific defines including:

+#define ia64_hint(x)

So I'd need Ken's patch on top of yours to make cpu_relax() actually do something, right?

I believe so. My patch from yesterday maps kernel internal definition of ia64_hint to icc intrinsic, which the standard intel icc header file doesn't know anything about. Regardless, we need that patch.

- Ken