pktgen: Fix Initialization fail leak.

PATCH New Luiz Fernando Capitulino 1 participant 1 message Jan 30, 2006

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Luiz Fernando Capitulino

author

2006-01-30 01:21 UTC #0 lore raw

PATCH 4/4 pktgen: Fix Initialization fail leak.

Even if pktgen's thread initialization fails for all CPUs, the module
will be successfully loaded.

This patch changes that behaivor, by returning error on module load time,
and also freeing all the resources allocated. It also prints a warning if a thread initialization has failed.

Signed-off-by Luiz Capitulino <[email protected]>

---

 net/core/pktgen.c |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)

909df2e921dabd2f43f80f4fe067bf3b86fbc3cd

net/core/pktgen.c +14 -1

index af310e5..3806068 100644
@@ -3136,11 +3136,24 @@ static int __init pg_init(void)
 	register_netdevice_notifier(&pktgen_notifier_block);
 
 	for_each_online_cpu(cpu) {
+		int err;
 		char buf[30];
 
 		sprintf(buf, "kpktgend_%i", cpu);
-		pktgen_create_thread(buf, cpu);
+		err = pktgen_create_thread(buf, cpu);
+		if (err)
+			printk("pktgen: WARNING: Cannot create thread for cpu %d (%d)\n",
+					cpu, err);
 	}
+
+	if (list_empty(&pktgen_threads)) {
+		printk("pktgen: ERROR: Initialization failed for all threads\n");
+		unregister_netdevice_notifier(&pktgen_notifier_block);
+		remove_proc_entry(PGCTRL, pg_proc_dir);
+		proc_net_remove(PG_PROC_DIR);
+		return -ENODEV;
+	}
+
 	return 0;
 }

Signature · 5 lines

1.1.5.g3480


-- 
Luiz Fernando N. Capitulino