Skip to contentSkip to conversation

rcu: undeclared variable used in documentation

PATCH In review Baruch Even 2 participants 2 messages Jan 31, 2006 – Feb 2, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rcu: undeclared variable used in documentation

The RCU documentation uses an fp variable which is not declared in the code snippets. Use the new_fp variable instead.

---

 Documentation/RCU/whatisRCU.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/RCU/whatisRCU.txt +2 -2
Index: htcp-abc/Documentation/RCU/whatisRCU.txt
===================================================================
@@ -357,7 +357,7 @@ uses of RCU may be found in listRCU.txt,
 		struct foo *new_fp;
 		struct foo *old_fp;
 
-		new_fp = kmalloc(sizeof(*fp), GFP_KERNEL);
+		new_fp = kmalloc(sizeof(*new_fp), GFP_KERNEL);
 		spin_lock(&foo_mutex);
 		old_fp = gbl_foo;
 		*new_fp = *old_fp;
@@ -456,7 +456,7 @@ The foo_update_a() function might then b
 		struct foo *new_fp;
 		struct foo *old_fp;
 
-		new_fp = kmalloc(sizeof(*fp), GFP_KERNEL);
+		new_fp = kmalloc(sizeof(*new_fp), GFP_KERNEL);
 		spin_lock(&foo_mutex);
 		old_fp = gbl_foo;
 		*new_fp = *old_fp;
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Baruch Even

The RCU documentation uses an fp variable which is not declared in the code snippets. Use the new_fp variable instead.

Good catch!!!

Thanx, Paul

Quoted 36 lines

---

 Documentation/RCU/whatisRCU.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: htcp-abc/Documentation/RCU/whatisRCU.txt
===================================================================

Documentation/RCU/whatisRCU.txt +2 -3
@@ -357,7 +357,7 @@ uses of RCU may be found in listRCU.txt,
 		struct foo *new_fp;
 		struct foo *old_fp;
 
-		new_fp = kmalloc(sizeof(*fp), GFP_KERNEL);
+		new_fp = kmalloc(sizeof(*new_fp), GFP_KERNEL);
 		spin_lock(&foo_mutex);
 		old_fp = gbl_foo;
 		*new_fp = *old_fp;
@@ -456,7 +456,7 @@ The foo_update_a() function might then b
 		struct foo *new_fp;
 		struct foo *old_fp;
 
-		new_fp = kmalloc(sizeof(*fp), GFP_KERNEL);
+		new_fp = kmalloc(sizeof(*new_fp), GFP_KERNEL);
 		spin_lock(&foo_mutex);
 		old_fp = gbl_foo;
 		*new_fp = *old_fp;
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/