Skip to contentSkip to conversation

align kenrel rbs on 128 byte

PATCH In review Chen, Kenneth W 6 participants 10 messages Jan 31, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/6 align kenrel rbs on 128 byte

The bottom of kernel rbs stack is the memory used to spill user dirty stack register partition when entering the kernel. This space is heavily used on every kernel entry and exit. It deserve having its own dedicated cache line and not to share with tail end of thread_info which is not used heavily.

Align the bottom of kernel rbs stack to 128 byte boundary.

include/asm-ia64/ptrace.h renamed from include/asm-ia64/ptrace.h.orig +1 -1
@@ -75,7 +75,7 @@
 # define KERNEL_STACK_SIZE_ORDER		0
 #endif
 
-#define IA64_RBS_OFFSET			((IA64_TASK_SIZE + IA64_THREAD_INFO_SIZE + 15) & ~15)
+#define IA64_RBS_OFFSET			((IA64_TASK_SIZE + IA64_THREAD_INFO_SIZE + 127) & ~127)
 #define IA64_STK_OFFSET			((1 << KERNEL_STACK_SIZE_ORDER)*PAGE_SIZE)
 
 #define KERNEL_STACK_SIZE		IA64_STK_OFFSET
#1 lore raw
Quoted 14 lines · "Chen, Kenneth W" (on Tue, 31 Jan 2006 00:48:28 -0800) wrote:

The bottom of kernel rbs stack is the memory used to spill user dirty stack register partition when entering the kernel. This space is heavily used on every kernel entry and exit. It deserve having its own dedicated cache line and not to share with tail end of thread_info which is not used heavily.

Align the bottom of kernel rbs stack to 128 byte boundary.

include/asm-ia64/ptrace.h line 81

Quoted 8 lines
include/asm-ia64/ptrace.h renamed from include/asm-ia64/ptrace.h.orig +1 -1
@@ -75,7 +75,7 @@
 # define KERNEL_STACK_SIZE_ORDER		0
 #endif
 
-#define IA64_RBS_OFFSET			((IA64_TASK_SIZE + IA64_THREAD_INFO_SIZE + 15) & ~15)
+#define IA64_RBS_OFFSET			((IA64_TASK_SIZE + IA64_THREAD_INFO_SIZE + 127) & ~127)
 #define IA64_STK_OFFSET			((1 << KERNEL_STACK_SIZE_ORDER)*PAGE_SIZE)
 
 #define KERNEL_STACK_SIZE		IA64_STK_OFFSET

The cache lines are not guaranteed to be 128 byte aligned, they were 64 on bigsur. Change 127 to (L1_CACHE_BYTES - 1).

#2 lore raw
In reply to Chen, Kenneth W

Keith Owens wrote on Tuesday, January 31, 2006 12:57 AM

Quoted 7 lines
Quoted 6 lines · "Chen, Kenneth W" (on Tue, 31 Jan 2006 00:48:28 -0800) wrote:

The bottom of kernel rbs stack is the memory used to spill user dirty stack register partition when entering the kernel. This space is heavily used on every kernel entry and exit. It deserve having its own dedicated cache line and not to share with tail end of thread_info which is not used heavily.

Quoted 7 lines
Quoted 4 lines

Align the bottom of kernel rbs stack to 128 byte boundary.

The cache lines are not guaranteed to be 128 byte aligned, they were 64 on bigsur. Change 127 to (L1_CACHE_BYTES - 1).

That did cross my mind and L1_CACHE_BYTES is such a misleading name. In my head, L1 means the cache level closest to the CPU core, but here it appears to represent last level cache line. Do we have the numbering scheme reversed? I have no idea what's going on here.

- Ken

p.s. It's amazing people is still using bigsur. Long live Itanium!

#3 lore raw
In reply to Chen, Kenneth W
Quoted 2 lines · Keith Owens

The cache lines are not guaranteed to be 128 byte aligned, they were 64 on bigsur.

A 128 byte aligned address is also 64 byte aligned.

Andreas.

Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
#4 lore raw
In reply to Chen, Kenneth W
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ken" = Chen, Kenneth W <[email protected]> writes:

Ken> Keith Owens wrote on Tuesday, January 31, 2006 12:57 AM

Quoted 2 lines
Quoted 2 lines

The cache lines are not guaranteed to be 128 byte aligned, they were 64 on bigsur. Change 127 to (L1_CACHE_BYTES - 1).

Ken> That did cross my mind and L1_CACHE_BYTES is such a misleading Ken> name. In my head, L1 means the cache level closest to the CPU Ken> core, but here it appears to represent last level cache line. Do Ken> we have the numbering scheme reversed? I have no idea what's Ken> going on here.

Ken,

Shouldn't this be SMP_CACHE_BYTES if anything?

Cheers,
Jes

#5 lore raw
In reply to Chen, Kenneth W
Quoted 10 lines · Kenneth Chen

Keith Owens wrote on Tuesday, January 31, 2006 12:57 AM

Quoted 3 lines

The cache lines are not guaranteed to be 128 byte aligned, they were 64 on bigsur. Change 127 to (L1_CACHE_BYTES - 1).

That did cross my mind and L1_CACHE_BYTES is such a misleading name. In my head, L1 means the cache level closest to the CPU core, but here it appears to represent last level cache line. Do we have the numbering scheme reversed? I have no idea what's going on here.

I agree that L1_CACHE_BYTES is misleading. Looking at the usage, most (if not all) references expect the last (external/FSB) cache line size, not caches closer to the core. As Jes points out SMP_CACHE_BYTES is more what they mean.

Why not just call it CACHE_BYTES, meaning the last cache level. Handling of caches closer to the core most likely should be through PAL, or, it really needed, use the engineering cache level prefix.

Signature · 2 lines
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          [email protected]
#6 lore raw
In reply to Chen, Kenneth W

Jes Sorensen wrote on Tuesday, January 31, 2006 3:01 AM

Quoted 11 lines

Ken> Keith Owens wrote on Tuesday, January 31, 2006 12:57 AM

Quoted 2 lines
Quoted 2 lines

The cache lines are not guaranteed to be 128 byte aligned, they were 64 on bigsur. Change 127 to (L1_CACHE_BYTES - 1).

Ken> That did cross my mind and L1_CACHE_BYTES is such a misleading Ken> name. In my head, L1 means the cache level closest to the CPU Ken> core, but here it appears to represent last level cache line. Do Ken> we have the numbering scheme reversed? I have no idea what's Ken> going on here.

Shouldn't this be SMP_CACHE_BYTES if anything?

Yeah, if nobody cares about UP performance. SMP_CACHE_BYTES is 8 bytes on UP kernel (though it doesn't seem that anyone cares about UP). I will consult Tony to see what he likes. I might settle with L1_CACHE_BYTES. I can just see people is going yell at me for having 125 column line :-p :-))

- Ken

#7 lore raw
In reply to Chen, Kenneth W

On Tue January 31 2006 08:25, Chen, Kenneth W wrote:

.
.
.>

Quoted 2 lines

Yeah, if nobody cares about UP performance. SMP_CACHE_BYTES is 8 bytes on UP kernel (though it doesn't seem that anyone cares about UP). I

Well, I care about UP. But HP, Intel and SGI have made it pretty clear they don't care about UP (or the customers that have UP machines)

Quoted 7 lines

will consult Tony to see what he likes. I might settle with L1_CACHE_BYTES. I can just see people is going yell at me for having 125 column line :-p :-))

- Ken

-

#8 lore raw
In reply to Chen, Kenneth W

Richard Harke wrote on Tuesday, January 31, 2006 11:59 AM

Quoted 5 lines
Quoted 2 lines

Yeah, if nobody cares about UP performance. SMP_CACHE_BYTES is 8 bytes on UP kernel (though it doesn't seem that anyone cares about UP). I

Well, I care about UP. But HP, Intel and SGI have made it pretty clear they don't care about UP (or the customers that have UP machines)

I heard you. L1_CACHE_BYTES it is, so everyone can be benefited from the change: merced processor, UP, SMP you name it.

- Ken

#9 lore raw
In reply to Chen, Kenneth W
Quoted 5 lines · Kenneth W

Richard Harke wrote on Tuesday, January 31, 2006 11:59 AM

Quoted 3 lines
Quoted 2 lines

Yeah, if nobody cares about UP performance. SMP_CACHE_BYTES is 8 bytes on UP kernel (though it doesn't seem that anyone cares about UP). I

Quoted 7 lines
Quoted 2 lines

Well, I care about UP. But HP, Intel and SGI have made it pretty clear they don't care about UP (or the customers that have UP machines)

I heard you. L1_CACHE_BYTES it is, so everyone can be benefited from the change: merced processor, UP, SMP you name it.

- Ken

Thanks

Richard