Skip to contentSkip to conversation

ISDN warning

DISCUSSION Karsten Keil 1 participant 1 message Feb 1, 2006 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 12 lines · Andrew Morton

Karsten, could you please take a look at fixing this?

drivers/isdn/hisax/hscx_irq.c: In function `hscx_interrupt':
drivers/isdn/hisax/hscx_irq.c:201: warning: comparison is always 1 due to width of bit-field

It's due to

	(PACKET_NOACK != bcs->tx_skb->pkt_type)

pkt_type is only three bit wide.

I think this should fix it for the moment, pkt_type 7 is not used yet and this is only used internal in hisax.

drivers/isdn/hisax/hisax.h +1 -1
diff -ur a/drivers/isdn/hisax/hisax.h b/drivers/isdn/hisax/hisax.h
@@ -217,7 +217,7 @@
 #define GROUP_TEI	127
 #define TEI_SAPI	63
 #define CTRL_SAPI	0
-#define PACKET_NOACK	250
+#define PACKET_NOACK	7
 
 /* Layer2 Flags */
 
Signature · 3 lines
Karsten Keil
SuSE Labs
ISDN development