+ update-mm-acx-driver-to-version-0331.patch added to -mm tree
Quoted 5 lines
(quoted diff) +3
-1-struct wlandevice { +struct acx_device { + /* most frequent accesses first (dereferencing and cache line!) */ +
Review
Quoted 10 lines
(quoted diff) +10
-0+ /*** Locking ***/ + struct semaphore sem; + spinlock_t lock; +#if defined(PARANOID_LOCKING) /* Lock debugging */ + const char *last_sem; + const char *last_lock; + unsigned long sem_time; + unsigned long lock_time; +#endif +
any chance of turning this into a mutex instead? (and you get some of the debugging for free instead that way)
Quoted 10 lines · Arjan van de Ven
Quoted 10 lines
(quoted diff) +8
-1-struct wlandevice { +struct acx_device { + /* most frequent accesses first (dereferencing and cache line!) */ + + /*** Locking ***/ + struct semaphore sem; + spinlock_t lock; +#if defined(PARANOID_LOCKING) /* Lock debugging */ + const char *last_sem;
Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +5
-0+ const char *last_lock; + unsigned long sem_time; + unsigned long lock_time; +#endif +any chance of turning this into a mutex instead? (and you get some of the debugging for free instead that way)
(/me is reading Ingo's docs...)
Nice :)
Yes, we will do the conversion later. For now we want our driver usable on vanilla 2.6.10.
--
vda