Skip to contentSkip to conversation

2.6.16-rc1-mm4 i386 atomic operations broken on SMP (in modules at least)

DISCUSSION Chuck Ebbert 1 participant 1 message Feb 2, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 6 lines · Andrew Morton
Quoted 3 lines · Chuck Ebbert

SMP alternatives is re-using the constant_tsc X86 feature bit.

Darn, how did you spot that?

I went looking for which bit represented X86_FEATURE_UP and there it was...

Quoted 2 lines

Should `feature_up' appear in /proc/cpuinfo?

Probably. The bug would have been nearly impossible if that had been done to begin with.

i386: show x86 feature "up" in cpuinfo

Show feature bit "up" (SMP kernel running on uniprocessor) in /proc/cpuinfo.

arch/i386/kernel/cpu/proc.c +1 -1
@@ -40,7 +40,7 @@ static int show_cpuinfo(struct seq_file 
 		/* Other (Linux-defined) */
 		"cxmmx", "k6_mtrr", "cyrix_arr", "centaur_mcr",
 		NULL, NULL, NULL, NULL,
-		"constant_tsc", NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+		"constant_tsc", "up", NULL, NULL, NULL, NULL, NULL, NULL,
 		NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
 		NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
 
Signature · 1 line
Chuck