swsusp: kill unneeded/unbalanced bio_get
Subsystems (2)
PATCH 1/1 swsusp: kill unneeded/unbalanced bio_get
Takashi pointed out that I don't bio_put in non-error cases, and says bio_get is not neccessary. It still works so I hope he's ok.
Signed-off-by Pavel Machek <[email protected]>
kernel/power/swsusp.c +0 -2
@@ -743,7 +743,6 @@ static int submit(int rw, pgoff_t page_oif (!bio)return -ENOMEM ; bio->bi_sector = page_off * (PAGE_SIZE >>9 ); -bio_get (bio); bio->bi_bdev = resume_bdev; bio->bi_end_io = end_io;
@@ -762,7 +761,6 @@ static int submit(int rw, pgoff_t page_oyield (); Done: -bio_put (bio);return error; }
Signature · 1 line
Thanks, Sharp!
PATCH 1/1 swsusp: kill unneeded/unbalanced bio_get (try 2)
In reply to a message not in the archiveI messed the first attempt up, it only moved leak to error path. Could you replace it with this?
---
Takashi pointed out that I don't bio_put in non-error cases, and says bio_get is not neccessary. It still works so I hope he's ok.
Signed-off-by Pavel Machek <[email protected]>
kernel/power/swsusp.c +0 -1
@@ -743,7 +743,6 @@ static int submit(int rw, pgoff_t page_oif (!bio)return -ENOMEM ; bio->bi_sector = page_off * (PAGE_SIZE >>9 ); -bio_get (bio); bio->bi_bdev = resume_bdev; bio->bi_end_io = end_io;
Signature · 1 line
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...