Skip to contentSkip to conversation

gdth: don't map zero-length requests

PATCH In review Christoph Hellwig 3 participants 3 messages Feb 5, 2006 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gdth: don't map zero-length requests

From: Jenx Axboe <[email protected]>

Don't map zero-length requests in gdth, zome architectures don't like that in their dma mapping routines.

[ I'm pretty sure Jens posted this before, but for some reason it got
forgotten --hch ]

drivers/scsi/gdth.c +1 -1
Index: linux-2.6/drivers/scsi/gdth.c
===================================================================
@@ -2816,7 +2816,7 @@
             }
 #endif
 
-        } else {
+        } else if (scp->request_bufflen) {
             scp->SCp.Status = GDTH_MAP_SINGLE;
             scp->SCp.Message = (read_write == 1 ? 
                 PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE);
#1 lore raw
Quoted 7 lines · Christoph Hellwig

From: Jenx Axboe <[email protected]>

Don't map zero-length requests in gdth, zome architectures don't like that in their dma mapping routines.

[ I'm pretty sure Jens posted this before, but for some reason it got
forgotten --hch ]

Thanks for reposting Christoph, James can you please pick this up?

Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 1 line · Jens Axboe

Thanks for reposting Christoph, James can you please pick this up?

Got it in scsi-rc-fixes-2.6

James