Skip to contentSkip to conversation

Make spi_print_msg more consistent

PATCH New Matthew Wilcox 1 participant 1 message Feb 7, 2006 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make spi_print_msg more consistent

Almost all the output from spi_print_msg() has a trailing space. This patch fixes up the three cases that don't.

Index: ./drivers/scsi/scsi_transport_spi.c
===================================================================
RCS file: /var/cvs/linux-2.6/drivers/scsi/scsi_transport_spi.c,v retrieving revision 1.24

drivers/scsi/scsi_transport_spi.c +3 -3
diff -u -p -r1.24 scsi_transport_spi.c
@@ -1101,7 +1133,7 @@ int spi_print_msg(const unsigned char *m
 				(int) msg[2]);
 		switch (msg[2]) {
 		case EXTENDED_MODIFY_DATA_POINTER:
-			printk("pointer = %d", (int) (msg[3] << 24) |
+			printk("pointer = %d ", (msg[3] << 24) |
 				(msg[4] << 16) | (msg[5] << 8) | msg[6]);
 			break;
 		case EXTENDED_SDTR:
@@ -1127,7 +1159,7 @@ int spi_print_msg(const unsigned char *m
 	/* Normal One byte */
 	} else if (msg[0] < 0x1f) {
 		if (msg[0] < ARRAY_SIZE(one_byte_msgs))
-			printk(one_byte_msgs[msg[0]]);
+			printk("%s ", one_byte_msgs[msg[0]]);
 		else
 			printk("reserved (%02x) ", msg[0]);
 		len = 1;
@@ -1141,7 +1173,7 @@ int spi_print_msg(const unsigned char *m
 				msg[0], msg[1]);
 		len = 2;
 	} else 
-		printk("reserved");
+		printk("reserved ");
 	return len;
 }
 EXPORT_SYMBOL(spi_print_msg);