Skip to contentSkip to conversation

Fix compile error in 8250_au1x00.c

PATCH Applied Jordan Crouse 3 participants 3 messages Feb 7, 2006 – Mar 2, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix compile error in 8250_au1x00.c

This patch fixes a compile error when building the 8250_au1x00 driver for the DB1550, which doesn't have a UART2 defined, resulting in a compile error.

There are additional rumors of strangeness on the DB1550, but those are unsubstantiated at this point. At least with this patch, it will compile.

Jordan

Signature · 4 lines
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>

[PATCH]: Fixup for the AU1X00 8250 driver

The DB1550 actually doesn't have a UART2. Remove it from the list.

---

 drivers/serial/8250_au1x00.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/serial/8250_au1x00.c +0 -1
index 06ae8fb..8d8d7a7 100644
@@ -56,7 +56,6 @@ static struct plat_serial8250_port au1x0
 #elif defined(CONFIG_SOC_AU1550)
 	PORT(UART0_ADDR, AU1550_UART0_INT),
 	PORT(UART1_ADDR, AU1550_UART1_INT),
-	PORT(UART2_ADDR, AU1550_UART2_INT),
 	PORT(UART3_ADDR, AU1550_UART3_INT),
 #elif defined(CONFIG_SOC_AU1200)
 	PORT(UART0_ADDR, AU1200_UART0_INT),
Applied
#1 lore raw
Quoted 1 line · Jordan Crouse

The DB1550 actually doesn't have a UART2. Remove it from the list.

Applied, thanks.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
#2 lore raw
In reply to Jordan Crouse
Quoted 3 lines · Jordan Crouse

There are additional rumors of strangeness on the DB1550, but those are unsubstantiated at this point. At least with this patch, it will compile.

I can confirm strangeness on Au1550, and I've pinned it down to wrong way of setting the divisor register. The alchemy uart have got a spearate register for divisor, while the driver tries to set the divisor latch just like on any 16550 uart.

How would be a good way of solving this? I can imagine a couple of ways:

1. Make divisor latch read/write a bit more abstract, so that a alternative function can be used for alchemy.

2. Add divisor latch to the alchemy uart register map. But since the divisor register is located in a single 32-bit register and the driver will try to access it one byte at a time; byte access would be needed. And this would add some endian handling...

Signature · 1 line
Jon Anders Haugum