Skip to contentSkip to conversation

drivers/media/dvb/bt8xx/: make 2 structs static

PATCH In review Adrian Bunk 3 participants 3 messages Feb 10, 2006 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/media/dvb/bt8xx/: make 2 structs static

This patch makes two needlessly global structs static.

---

 drivers/media/dvb/bt8xx/bt878.c |    2 +-
 drivers/media/dvb/bt8xx/dst.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/media/dvb/bt8xx/bt878.c renamed from drivers/media/dvb/bt8xx/bt878.c.old +1 -1
@@ -382,7 +382,7 @@
 EXPORT_SYMBOL(bt878_device_control);
 
 
-struct cards card_list[] __devinitdata = {
+static struct cards card_list[] __devinitdata = {
 
 	{ 0x01010071, BTTV_BOARD_NEBULA_DIGITV,			"Nebula Electronics DigiTV" },
 	{ 0x07611461, BTTV_BOARD_AVDVBT_761,			"AverMedia AverTV DVB-T 761" },
drivers/media/dvb/bt8xx/dst.c renamed from drivers/media/dvb/bt8xx/dst.c.old +1 -1
@@ -602,7 +602,7 @@
 
 */
 
-struct dst_types dst_tlist[] = {
+static struct dst_types dst_tlist[] = {
 	{
 		.device_id = "200103A",
 		.offset = 0,
#1 lore raw
Quoted 26 lines · Adrian Bunk

This patch makes two needlessly global structs static.

---

 drivers/media/dvb/bt8xx/bt878.c |    2 +-
 drivers/media/dvb/bt8xx/dst.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/media/dvb/bt8xx/bt878.c renamed from drivers/media/dvb/bt8xx/bt878.c.old +1 -1
@@ -382,7 +382,7 @@
 EXPORT_SYMBOL(bt878_device_control);
 
 
-struct cards card_list[] __devinitdata = {
+static struct cards card_list[] __devinitdata = {
 
 	{ 0x01010071, BTTV_BOARD_NEBULA_DIGITV,			"Nebula Electronics DigiTV" },
 	{ 0x07611461, BTTV_BOARD_AVDVBT_761,			"AverMedia AverTV DVB-T 761" },

drivers/media/dvb/bt8xx/dst.c

Quoted 10 lines
drivers/media/dvb/bt8xx/dst.c renamed from drivers/media/dvb/bt8xx/dst.c.old +1 -2
@@ -602,7 +602,7 @@
 
 */
 
-struct dst_types dst_tlist[] = {
+static struct dst_types dst_tlist[] = {
 	{
 		.device_id = "200103A",
 		.offset = 0,
 
-

Ack'd-by: Manu Abraham <[email protected]>

#2 lore raw

Re: [v4l-dvb-maintainer] Re: [2.6 patch] drivers/media/dvb/bt8xx/: make2 structs static

Hi,

looks good. Thanks.

Best,
Florian

----- Original Message ----- From: "Manu Abraham" <[email protected]>
To: "Adrian Bunk" <[email protected]>
Cc: <[email protected]>; <[email protected]>
Sent: Friday, February 10, 2006 6:38 AM
Subject: [v4l-dvb-maintainer] Re: [2.6 patch] drivers/media/dvb/bt8xx/: make2 structs static

Quoted 46 lines
Quoted 27 lines · Adrian Bunk

This patch makes two needlessly global structs static.

---

 drivers/media/dvb/bt8xx/bt878.c |    2 +-
 drivers/media/dvb/bt8xx/dst.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/bt878.c.old

2006-02-09 22:09:00.000000000 +0100

+++ linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/bt878.c 2006-02-09 22:09:07.000000000 +0100

drivers/media/dvb/bt8xx/bt878.c renamed from drivers/media/dvb/bt8xx/bt878.c.old +1 -1
@@ -382,7 +382,7 @@
 EXPORT_SYMBOL(bt878_device_control);
 -struct cards card_list[] __devinitdata = {
+static struct cards card_list[] __devinitdata = {
 { 0x01010071, BTTV_BOARD_NEBULA_DIGITV, "Nebula Electronics DigiTV" },
 { 0x07611461, BTTV_BOARD_AVDVBT_761, "AverMedia AverTV DVB-T 761" },
--- linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/dst.c.old 
2006-02-09 22:09:21.000000000 +0100

+++ linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/dst.c 2006-02-09 22:09:29.000000000 +0100

drivers/media/dvb/bt8xx/dst.c line 608

Quoted 8 lines
drivers/media/dvb/bt8xx/dst.c renamed from drivers/media/dvb/bt8xx/dst.c.old +1 -1
@@ -602,7 +602,7 @@
 */
 -struct dst_types dst_tlist[] = {
+static struct dst_types dst_tlist[] = {
 {
 .device_id = "200103A",
 .offset = 0,
 
-

Ack'd-by: Manu Abraham <[email protected]>

_______________________________________________
v4l-dvb-maintainer mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer