Skip to contentSkip to conversation

Memory hotplug for new nodes with pgdat allocation.(allow -EEXIST of add_memory)

PATCH In review Yasunori Goto 1 participant 1 message Feb 10, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 10/10 Memory hotplug for new nodes with pgdat allocation.(allow -EEXIST of add_memory)

When acpi_memory_device_init() is called at boottime to register struct memory acpi_memory_device. So, acpi_bus_add() are called via acpi_driver_attach(). But it also calls ops->start() function.
It is called even if the memory blocks are initialized at early boottime. In this case add_memory() return -EEXIST, and the memory blocks becomes INVALID state even if it is normal.

This is patch for it.

Index: pgdat2/drivers/acpi/acpi_memhotplug.c
=================================--- pgdat2.orig/drivers/acpi/acpi_memhotplug.c 2006-02-10 15:35:34.000000000 +0900
+++ pgdat2/drivers/acpi/acpi_memhotplug.c 2006-02-10 15:35:36.000000000 +0900
@@ -201,8 +201,18 @@ static int acpi_memory_enable_device(str
* Note: Assume that this function returns zero on success */
result = add_memory(mem_device->start_addr, mem_device->length);
- if (result) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "\nadd_memory failed\n"));
+ switch(result) {
+ case 0:
+ break;
+ case -EEXIST:
+ ACPI_DEBUG_PRINT((ACPI_DB_INFO,

+				  "\nmemory start=%lu size=%lu has already existed\n",
+				  mem_device->start_addr,
+				  mem_device->length));

+ return 0;
+ default:
+ ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+ "\nadd_memory failed result=%d\n", result));
mem_device->state = MEMORY_INVALID_STATE; return result;
}

Signature · 1 line
Yasunori Goto