Skip to contentSkip to conversation

+ vmscan-rename-functions.patch added to -mm tree

DISCUSSION Coywolf Qi Hunt 3 participants 5 messages Feb 15, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

2006/2/12, [email protected] <[email protected]>:

Quoted 25 lines

The patch titled

vmscan: rename functions

has been added to the -mm tree. Its filename is

vmscan-rename-functions.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this

From: Andrew Morton <[email protected]>

We have:

        try_to_free_pages
        ->shrink_caches(struct zone **zones, ..)
          ->shrink_zone(struct zone *, ...)
            ->shrink_cache(struct zone *, ...)
              ->shrink_list(struct list_head *, ...)

which is fairly irrational.

Quoted 7 lines

Rename things so that we have

        try_to_free_pages
        ->shrink_zones(struct zone **zones, ..)
          ->shrink_zone(struct zone *, ...)
            ->do_shrink_zone(struct zone *, ...)
              ->shrink_page_list(struct list_head *, ...)

Every time I read this part it annoys me. Thanks.
--
Coywolf Qi Hunt

#2 lore raw
Quoted 28 lines · Coywolf Qi Hunt

2006/2/12, [email protected] <[email protected]>:

Quoted 26 lines

The patch titled

vmscan: rename functions

has been added to the -mm tree. Its filename is

vmscan-rename-functions.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this

From: Andrew Morton <[email protected]>

We have:

       try_to_free_pages
       ->shrink_caches(struct zone **zones, ..)
         ->shrink_zone(struct zone *, ...)
           ->shrink_cache(struct zone *, ...)
             ->shrink_list(struct list_head *, ...)

which is fairly irrational.

Rename things so that we have

Quoted 8 lines
Quoted 5 lines
       try_to_free_pages
       ->shrink_zones(struct zone **zones, ..)
         ->shrink_zone(struct zone *, ...)
           ->do_shrink_zone(struct zone *, ...)
             ->shrink_page_list(struct list_head *, ...)

Every time I read this part it annoys me. Thanks.

I don't much care, but if there is renaming afoot, I'd vote for

->shrink_zones(struct zone **zones, ..)
->shrink_zone(struct zone *, ...)
->shrink_inactive_list(struct zone *, ...)
->shrink_page_list(struct list_head *, ...)
->shrink_active_list (alternatively, leave as refill_inactive_list)

shrink_zone and do_shrink_zone don't really say any more to me than shrink_zone and shrink_cache.

Signature · 2 lines
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
#3 lore raw
Quoted 40 lines · Nick Piggin
Quoted 28 lines · Coywolf Qi Hunt

2006/2/12, [email protected] <[email protected]>:

Quoted 26 lines

The patch titled

vmscan: rename functions

has been added to the -mm tree. Its filename is

vmscan-rename-functions.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this

From: Andrew Morton <[email protected]>

We have:

       try_to_free_pages
       ->shrink_caches(struct zone **zones, ..)
         ->shrink_zone(struct zone *, ...)
           ->shrink_cache(struct zone *, ...)
             ->shrink_list(struct list_head *, ...)

which is fairly irrational.

Rename things so that we have

Quoted 8 lines
Quoted 5 lines
       try_to_free_pages
       ->shrink_zones(struct zone **zones, ..)
         ->shrink_zone(struct zone *, ...)
           ->do_shrink_zone(struct zone *, ...)
             ->shrink_page_list(struct list_head *, ...)

Every time I read this part it annoys me. Thanks.

I don't much care, but if there is renaming afoot, I'd vote for

Quoted 8 lines

->shrink_zones(struct zone **zones, ..)
->shrink_zone(struct zone *, ...)
->shrink_inactive_list(struct zone *, ...)

    ->shrink_page_list(struct list_head *, ...)

->shrink_active_list (alternatively, leave as refill_inactive_list)

shrink_zone and do_shrink_zone don't really say any more to me than shrink_zone and shrink_cache.

I know not everybody believes in a plugable reclaim policy, but that is what I'm building. And from that POV I'd rather not see the active/inactive names get used here.

My vote goes to Coywolf's suggestion.

Peter

#4 lore raw
Quoted 10 lines · Peter Zijlstra
Quoted 2 lines · Nick Piggin

shrink_zone and do_shrink_zone don't really say any more to me than shrink_zone and shrink_cache.

I know not everybody believes in a plugable reclaim policy, but that is what I'm building. And from that POV I'd rather not see the active/inactive names get used here.

active/inactive is what we have now. If you manage to get a pluggable reclaim policy merged then I assure you, renaming these yet again will be the least of your worries :)

Quoted 2 lines

My vote goes to Coywolf's suggestion.

What was that?

Signature · 2 lines
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
#5 lore raw
Quoted 7 lines · Nick Piggin
Quoted 6 lines · Peter Zijlstra
Quoted 2 lines · Nick Piggin

shrink_zone and do_shrink_zone don't really say any more to me than shrink_zone and shrink_cache.

Quoted 8 lines
Quoted 4 lines

I know not everybody believes in a plugable reclaim policy, but that is what I'm building. And from that POV I'd rather not see the active/inactive names get used here.

active/inactive is what we have now. If you manage to get a pluggable reclaim policy merged then I assure you, renaming these yet again will be the least of your worries :)

True indeed.

Quoted 4 lines
Quoted 2 lines

My vote goes to Coywolf's suggestion.

What was that?

Hmm, seems like I shouldn't read email before waking up, apparently I got the quoting levels mixed up.

Anyway, this one:

Quoted 5 lines
Quoted 5 lines
       try_to_free_pages
       ->shrink_zones(struct zone **zones, ..)
         ->shrink_zone(struct zone *, ...)
           ->do_shrink_zone(struct zone *, ...)
             ->shrink_page_list(struct list_head *, ...)