Skip to contentSkip to conversation

sym2: Mask off opcode from RBC

PATCH New Matthew Wilcox 1 participant 1 message Feb 12, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sym2: Mask off opcode from RBC

pm->sg.size is set from the Residual Byte Count register. However, the upper byte of the RBC is the opcode of the instruction that was executing, so we need to mask it off. This fixes some spurious rejects of IGNORE WIDE RESIDUE messages.

[James, please apply to scsi-rc-fixes]

Index: ./drivers/scsi/sym53c8xx_2/sym_hipd.c
===================================================================
RCS file: /var/lib/cvs/linux-2.6/drivers/scsi/sym53c8xx_2/sym_hipd.c,v retrieving revision 1.79
retrieving revision 1.80

drivers/scsi/sym53c8xx_2/sym_hipd.c +1 -1
diff -u -p -r1.79 -r1.80
@@ -3596,7 +3596,7 @@ static int sym_evaluate_dp(struct sym_hc
 
 	if (pm) {
 		dp_scr  = scr_to_cpu(pm->ret);
-		dp_ofs -= scr_to_cpu(pm->sg.size);
+		dp_ofs -= scr_to_cpu(pm->sg.size) & 0x00ffffff;
 	}
 
 	/*