Skip to contentSkip to conversation

kprobes depends on xmon

PATCH In review Olaf Hering 2 participants 3 messages Feb 14, 2006 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kprobes depends on xmon

KPROBES depends on XMON.
arch/powerpc/lib/step.c is only compiled if CONFIG_XMON is enabled.

arch/powerpc/kernel/built-in.o:
In function resume_execution':arch/powerpc/kernel/kprobes.c:331: undefined reference to .emulate_step'

 arch/powerpc/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/Kconfig +1 -1
Index: linux-2.6.16-rc3-olh/arch/powerpc/Kconfig
===================================================================
@@ -963,7 +963,7 @@ source "arch/powerpc/oprofile/Kconfig"
 
 config KPROBES
 	bool "Kprobes (EXPERIMENTAL)"
-	depends on PPC64
+	depends on PPC64 && XMON
 	help
 	  Kprobes allows you to trap at almost any kernel address and
 	  execute a callback function.  register_kprobe() establishes
#1 lore raw
Quoted 7 lines · Olaf Hering

KPROBES depends on XMON.
arch/powerpc/lib/step.c is only compiled if CONFIG_XMON is enabled.

arch/powerpc/kernel/built-in.o:
In function resume_execution':arch/powerpc/kernel/kprobes.c:331: undefined reference to .emulate_step'

Please compile step.o if either CONFIG_KPROBES or CONFIG_XMON is defined instead of adding a depency.

#2 lore raw

PATCH 1/1 kprobes needs emulate_step()

Quoted 11 lines · Christoph Hellwig
Quoted 7 lines · Olaf Hering

KPROBES depends on XMON.
arch/powerpc/lib/step.c is only compiled if CONFIG_XMON is enabled.

arch/powerpc/kernel/built-in.o:
In function resume_execution':arch/powerpc/kernel/kprobes.c:331: undefined reference to .emulate_step'

Please compile step.o if either CONFIG_KPROBES or CONFIG_XMON is defined instead of adding a depency.

(This one seems to work without warning about duplicate object files or something.)

KPROBES needs emulate_step()

arch/powerpc/kernel/built-in.o:
In function resume_execution':arch/powerpc/kernel/kprobes.c:331: undefined reference to .emulate_step'

 arch/powerpc/lib/Makefile |    1 +
 1 files changed, 1 insertion(+)
arch/powerpc/lib/Makefile +1 -0
Index: linux-2.6.16-rc3-olh/arch/powerpc/lib/Makefile
===================================================================
@@ -12,6 +12,7 @@ obj-$(CONFIG_PPC64)	+= checksum_64.o cop
 			   memcpy_64.o usercopy_64.o mem_64.o string.o \
 			   strcase.o
 obj-$(CONFIG_PPC_ISERIES) += e2a.o
+obj-$(CONFIG_KPROBES)	+= sstep.o
 obj-$(CONFIG_XMON)	+= sstep.o
 
 ifeq ($(CONFIG_PPC64),y)