Skip to contentSkip to conversation

drivers/media/video/saa7115.c misreports max. value of contrast and saturation

DISCUSSION Kyler Laird 4 participants 6 messages Feb 15, 2006 – Mar 9, 2006

lore
Share & tools
lore
#0 lore raw

For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum value in v4l2_queryctrl is set to 255 for both of these items. This means that programs (like MythTV) which set the contrast and saturation to the midvalue (127) get *full* contrast and saturation. (It's not pretty.)

Setting the maximum values to 127 solves this problem.

Please copy me on responses.

Thank you.

--kyler

#1 lore raw
Quoted 8 lines · Kyler Laird

For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum value in v4l2_queryctrl is set to 255 for both of these items. This means that programs (like MythTV) which set the contrast and saturation to the midvalue (127) get *full* contrast and saturation. (It's not pretty.)

Setting the maximum values to 127 solves this problem.

Mauro, can you comment on this issue?

Quoted 5 lines

Please copy me on responses.

Thank you.

--kyler

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
Quoted 11 lines · Adrian Bunk
Quoted 8 lines · Kyler Laird

For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum value in v4l2_queryctrl is set to 255 for both of these items. This means that programs (like MythTV) which set the contrast and saturation to the midvalue (127) get *full* contrast and saturation. (It's not pretty.)

Setting the maximum values to 127 solves this problem.

Mauro, can you comment on this issue?

It's fixed with the patch with subject '[PATCH 08/13] Fix maximum for the saturation and contrast controls.' It was posted by Mauro to the linux mailinglist a week ago. I hope it will be fixed in 2.6.16, but Mauro should know more about it. It was a stupid copy-and-paste bug so I see no reason why it shouldn't go in.

Quoted 8 lines
Quoted 5 lines

Please copy me on responses.

Thank you.

--kyler

cu
Adrian

#3 lore raw
In reply to Adrian Bunk

Adrian,

Em Qua, 2006-03-08 às 22:19 +0100, Adrian Bunk escreveu:

Quoted 9 lines · Kyler Laird
Quoted 8 lines

For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum value in v4l2_queryctrl is set to 255 for both of these items. This means that programs (like MythTV) which set the contrast and saturation to the midvalue (127) get *full* contrast and saturation. (It's not pretty.)

Quoted 3 lines
Quoted 1 line

Setting the maximum values to 127 solves this problem.

Mauro, can you comment on this issue?

Yes. Patch is already available at both git and mercurial trees, fixing it for saa7115 and cx25840:

http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=b77c2f933b620bccaa751d556c1aa2fca30de7ec;style=gitweb

Quoted 10 lines
Quoted 6 lines

Please copy me on responses.

Thank you.

--kyler

cu
Adrian

Cheers,
Mauro.

#4 lore raw
Quoted 13 lines · Mauro Carvalho Chehab

Adrian,

Em Qua, 2006-03-08 às 22:19 +0100, Adrian Bunk escreveu:

Quoted 9 lines · Kyler Laird
Quoted 8 lines

For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum value in v4l2_queryctrl is set to 255 for both of these items. This means that programs (like MythTV) which set the contrast and saturation to the midvalue (127) get *full* contrast and saturation. (It's not pretty.)

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Setting the maximum values to 127 solves this problem.

Mauro, can you comment on this issue?

Yes. Patch is already available at both git and mercurial trees, fixing it for saa7115 and cx25840:

http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=b77c2f933b620bccaa751d556c1aa2fca30de7ec;style=gitweb

This patch seems to be 2.1.16 stuff?

Quoted 2 lines

Cheers,
Mauro.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#5 lore raw

Em Qui, 2006-03-09 às 00:46 +0100, Adrian Bunk escreveu:

Quoted 16 lines · Mauro Carvalho Chehab
Quoted 15 lines

Adrian,

Em Qua, 2006-03-08 às 22:19 +0100, Adrian Bunk escreveu:

Quoted 11 lines · Kyler Laird
Quoted 9 lines

For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum value in v4l2_queryctrl is set to 255 for both of these items. This means that programs (like MythTV) which set the contrast and saturation to the midvalue (127) get *full* contrast and saturation. (It's not pretty.)

Setting the maximum values to 127 solves this problem.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Mauro, can you comment on this issue?

Yes. Patch is already available at both git and mercurial trees, fixing it for saa7115 and cx25840:

http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=b77c2f933b620bccaa751d556c1aa2fca30de7ec;style=gitweb

This patch seems to be 2.1.16 stuff?

I think you meant 2.6.16 :) Yes, it is. I've already sent an email to Linus for him to pull it, among with some other pending patches.

Quoted 7 lines
Quoted 3 lines

Cheers,
Mauro.

cu
Adrian

Cheers,
Mauro.