Skip to contentSkip to conversation

s390: fix assignment instead of check in ccw_device_set_online()

PATCH New Heiko Carstens 1 participant 1 message Feb 16, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/3 s390: fix assignment instead of check in ccw_device_set_online()

From: Cornelia Huck <[email protected]>

Fix assignment instead of check in ccw_device_set_online(). Also remove unneeded assignment in ccw_device_do_sense().

---

 drivers/s390/cio/device.c        |    2 +-
 drivers/s390/cio/device_status.c |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/s390/cio/device.c +1 -1
diff -urpN linux-2.6/drivers/s390/cio/device.c linux-2.6-patched/drivers/s390/cio/device.c
@@ -359,7 +359,7 @@ ccw_device_set_online(struct ccw_device 
 	else 
 		pr_debug("ccw_device_offline returned %d, device %s\n",
 			 ret, cdev->dev.bus_id);
-	return (ret = 0) ? -ENODEV : ret;
+	return (ret == 0) ? -ENODEV : ret;
 }
 
 static ssize_t
drivers/s390/cio/device_status.c +0 -1
diff -urpN linux-2.6/drivers/s390/cio/device_status.c linux-2.6-patched/drivers/s390/cio/device_status.c
@@ -317,7 +317,6 @@ ccw_device_do_sense(struct ccw_device *c
 	/*
 	 * We have ending status but no sense information. Do a basic sense.
 	 */
-	sch = to_subchannel(cdev->dev.parent);
 	sch->sense_ccw.cmd_code = CCW_CMD_BASIC_SENSE;
 	sch->sense_ccw.cda = (__u32) __pa(cdev->private->irb.ecw);
 	sch->sense_ccw.count = SENSE_MAX_COUNT;