Skip to contentSkip to conversation

New: Initio sbp2 causes: "slab error in cache_free_debugcheck(): cache `size-512(DMA)': double free, or memory outside" object was overwritten

Bugme-new Stefan Richter 2 participants 3 messages Feb 22, 2006 6 messages not in the archive SCSI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 3 lines · Bernhard Kaindl

I tested the current ieee1394 cumulative patch in -mm1 from ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc4/2.6.16-rc4-mm1/broken-out/git-ieee1394.patch with my Initio and it still triggered the CONFIG_DEBUG_SLAB detector.

What I don't understand is why mode page 8 is still accessed in your log: http://bugzilla.kernel.org/attachment.cgi?id=7432&action=view
(Log lines "command: Mode Sense (10): 5a 00 08 00 00 00 00 00 d9 00", "SCSI transfer size = 17d9" --- yeah, into a 512 Bytes big buffer, "sda: got wrong page".) Could you please add a printk() or SBP2_INFO() within the if() clause of sbp2scsi_slave_alloc() to make sure it is entered? Could you also add the line

	SBP2_INFO("skip_ms_page_8 = %d", sdev->skip_ms_page_8);

before the return in sbp2scsi_slave_configure()? Not that your kernel looses the flag somewhere along the way...

Quoted 9 lines

This patch from Al Viro fixed the slab message for me:

Re: TYPE_RBC cache fixes (sbp2.c affected)
2006-02-21 13:51
http://sourceforge.net/mailarchive/message.php?msg_id=14879016

Bernhard
--
PS: My bug report for this was: http://bugzilla.kernel.org/show_bug.cgi?id=6114

Al's patch is certainly better since it adds checks to the actual affected code region, i.e. mode_sense handling in the SCSI layers. James, would you integrate this patch?

However sbp2 will keep some sort of skip_ms_page_8 blacklisting anyway because of different issues with other bridges.

Signature · 10 lines
Stefan Richter
-=====-=-==- --=- =-==-
http://arcgraph.de/sr/


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
#7 lore raw
Quoted 6 lines · Stefan Richter

Al's patch is certainly better since it adds checks to the actual affected code region, i.e. mode_sense handling in the SCSI layers. James, would you integrate this patch?

However sbp2 will keep some sort of skip_ms_page_8 blacklisting anyway because of different issues with other bridges.

Sure, but for this bridge it's not needed - with that fix we get the right data out of bridge response. Note
+sda: missing header in MODE_SENSE response
and
+SCSI device sda: drive cache: write back
in that diff. The former is exactly what we get when we detect that sort of breakage (bare page 6 without header) and the latter is where we manage to get the cache type.

#8 lore raw
Quoted 7 lines · Al Viro
Quoted 3 lines · Stefan Richter

Al's patch is certainly better since it adds checks to the actual affected code region, i.e. mode_sense handling in the SCSI layers. James, would you integrate this patch?

However sbp2 will keep some sort of skip_ms_page_8 blacklisting anyway because of different issues with other bridges.

Quoted 8 lines

Sure, but for this bridge it's not needed - with that fix we get the right data out of bridge response. Note
+sda: missing header in MODE_SENSE response
and
+SCSI device sda: drive cache: write back
in that diff. The former is exactly what we get when we detect that sort of breakage (bare page 6 without header) and the latter is where we manage to get the cache type.

Yes, you are definitly right about it.

Signature · 10 lines
Stefan Richter
-=====-=-==- --=- =-==-
http://arcgraph.de/sr/


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642