Skip to contentSkip to conversation

version.h should depend on .kernelrelease

PATCH In review Jan Beulich 2 participants 2 messages Feb 22, 2006 – Feb 23, 2006 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 version.h should depend on .kernelrelease

Rebuilding a previously built tree while using make's -j options from time to time results in the version.h check running at the same time as the updating of .kernelrelease, resulting in UTS_RELEASE remaining an empty string (and as a side effect causing the entire kernel to be rebuilt).

Makefile renamed from home/jbeulich/tmp/linux-2.6.16-rc4/Makefile +1 -1
diff -Npru /home/jbeulich/tmp/linux-2.6.16-rc4/Makefile 2.6.16-rc4-version.h-depends-on-kernelrelease/Makefile
@@ -905,7 +905,7 @@ define filechk_version.h
 	)
 endef
 
-include/linux/version.h: $(srctree)/Makefile .config FORCE
+include/linux/version.h: $(srctree)/Makefile .config .kernelrelease FORCE
 	$(call filechk,version.h)
 
 # ---------------------------------------------------------------------------
#1 lore raw
Quoted 4 lines · Jan Beulich

Rebuilding a previously built tree while using make's -j options from time to time results in the version.h check running at the same time as the updating of .kernelrelease, resulting in UTS_RELEASE remaining an empty string (and as a side effect causing the entire kernel to be rebuilt).

Thanks Jan, applied to my kbuild.git tree.

Sam