Skip to contentSkip to conversation

x86: start early_printk at sensible screen row

PATCH Chuck Ebbert 1 participant 1 message Feb 25, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 11 lines · Andrew Morton
Quoted 3 lines

Use boot info to start early_printk() at the proper row on VGA console.

Define "proper".

Review

Quoted 3 lines
(quoted diff) +1 -1
-           current_ypos = max_ypos;
+           current_ypos = SCREEN_INFO.orig_y;

Is that the place at which the boot loader left the cursor?

Yes, that's what I should have said instead of "proper".

So far I can't break it; after booting with "vga=ask" and doing some things at the prompt, the kernel output still starts at the right place.

But the emergency fallback early_printk still starts at a fixed place and the x86_64 'direct mapping' message will screw things up when there's no earlyprintk boot parameter.

Signature · 2 lines
Chuck
"Equations are the Devil's sentences."  --Stephen Colbert