bug in hci_uart_tx_wakeup() causes panic when UART removed

Bluez-devel Karol Kozimor 3 participants 4 messages Feb 26, 2006 Bluetooth drivers

Share & tools

Karol Kozimor

author

2006-02-26 14:59 UTC #0 lore raw

Hi,
Under specific circumstances, hci_uart_tx_wakeup() seems to call tty->driver->write() without checking if the tty is alive, which effectively causes a nasty panic in uart_write(). From what I've read so far it seems that hci_ldisc.c is to blame, so I'm reporting it here.

Best regards,

Signature · 13 lines

Karol 'sziwan' Kozimor
[email protected]


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Marcel Holtmann

maintainer

2006-02-26 21:40 UTC #1 lore raw

Hi Karol,

Quoted 4 lines

Under specific circumstances, hci_uart_tx_wakeup() seems to call tty->driver->write() without checking if the tty is alive, which effectively causes a nasty panic in uart_write(). From what I've read so far it seems that hci_ldisc.c is to blame, so I'm reporting it here.

and I haven't seen a patch for it or any advice on how to fix this. At the moment I have no time to fully track this down.

Regards

Marcel

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Russell King

2006-02-26 22:47 UTC #2 lore raw

In reply to Karol Kozimor

Quoted 6 lines · Karol Kozimor

Hi,
Under specific circumstances, hci_uart_tx_wakeup() seems to call tty->driver->write() without checking if the tty is alive, which effectively causes a nasty panic in uart_write(). From what I've read so far it seems that hci_ldisc.c is to blame, so I'm reporting it here.

Quoted 6 lines

This is related to:
http://sourceforge.net/mailarchive/message.php?msg_id=14724441
See also:
http://bugme.osdl.org/show_bug.cgi?id=6131
http://bugzilla.kernel.org/show_bug.cgi?id=5958

As a priority, I especially recommend bluetooth developers read:

http://bugzilla.kernel.org/show_bug.cgi?id=5958#c2

where bug 6131 was predicted.

Signature · 12 lines

Russell King


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Marcel Holtmann

maintainer

2006-02-26 23:58 UTC #3 lore raw

Hi Russell,

Quoted 12 lines

Quoted 11 lines
Under specific circumstances, hci_uart_tx_wakeup() seems to call tty->driver->write() without checking if the tty is alive, which effectively causes a nasty panic in uart_write(). From what I've read so far it seems that hci_ldisc.c is to blame, so I'm reporting it here.
This is related to:
http://sourceforge.net/mailarchive/message.php?msg_id=14724441
See also:
http://bugme.osdl.org/show_bug.cgi?id=6131
http://bugzilla.kernel.org/show_bug.cgi?id=5958

Quoted 5 lines

As a priority, I especially recommend bluetooth developers read:
http://bugzilla.kernel.org/show_bug.cgi?id=5958#c2
where bug 6131 was predicted.

I saw that we didn't implement the hangup callback. Will it be sufficient to use it to shutdown our HCI interface?

Regards

Marcel