Skip to contentSkip to conversation

Export spi_populate_* functions

PATCH In review Matthew Wilcox 3 participants 5 messages Feb 27, 2006 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Export spi_populate_* functions

These functions should be usable by modules.

drivers/scsi/scsi_transport_spi.c +3 -0
diff -u ./drivers/scsi/scsi_transport_spi.c ./drivers/scsi/scsi_transport_spi.c
@@ -1062,6 +1061,7 @@
 	msg[3] = width;
 	return 4;
 }
+EXPORT_SYMBOL(spi_populate_width_msg);
 
 int spi_populate_sync_msg(unsigned char *msg, int period, int offset)
 {
@@ -1072,6 +1072,7 @@
 	msg[4] = offset;
 	return 5;
 }
+EXPORT_SYMBOL(spi_populate_sync_msg);
 
 int spi_populate_ppr_msg(unsigned char *msg, int period, int offset,
 		int width, int options)
@@ -1086,6 +1087,7 @@
 	msg[7] = options;
 	return 8;
 }
+EXPORT_SYMBOL(spi_populate_ppr_msg);
 
 #ifdef CONFIG_SCSI_CONSTANTS
 static const char * const one_byte_msgs[] = {
#1 lore raw
Quoted 1 line · Matthew Wilcox

These functions should be usable by modules.

since this is new and very much linux specific code, shouldn't these be _GPL exports?

#4 lore raw
In reply to Arjan van de Ven
Quoted 5 lines · Arjan van de Ven
Quoted 1 line · Matthew Wilcox

These functions should be usable by modules.

since this is new and very much linux specific code, shouldn't these be _GPL exports?

how is it very much linux specific? these functions take a char pointer and fill in that buffer with the messages defined in the scsi specs. there's no linux data structures used.

http://git.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=blobdiff;h=c0051a432a97d1f9181229aff0fc9484df10c342;hp=97f4be62f748af9791d1a1932244ea604a1432e7;hb=49db0bbd2a3648b1da8dee31f803fc52a06c57e1;f=drivers/scsi/scsi_transport_spi.c

#3 lore raw
In reply to James Bottomley
Quoted 10 lines · James Bottomley
Quoted 2 lines · Arjan van de Ven

since this is new and very much linux specific code, shouldn't these be _GPL exports?

Actually, try this commit:

http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=e855d0f4b3d4c421d4de5f30582e3aa579184adb

It's been there since I put the patch in ... otherwise none of my modules would build ...

How strange; when I looked on gitweb an hour ago, it wasn't there, yet now it is.