Export spi_populate_* functions
PATCH 1/1 Export spi_populate_* functions
These functions should be usable by modules.
drivers/scsi/scsi_transport_spi.c +3 -0
@@ -1062,6 +1061,7 @@ msg[3 ] = width;return 4 ; } +EXPORT_SYMBOL (spi_populate_width_msg);int spi_populate_sync_msg (unsigned char *msg,int period,int offset) {
@@ -1072,6 +1072,7 @@ msg[4 ] = offset;return 5 ; } +EXPORT_SYMBOL (spi_populate_sync_msg);int spi_populate_ppr_msg (unsigned char *msg,int period,int offset,int width,int options)
@@ -1086,6 +1087,7 @@ msg[7 ] = options;return 8 ; } +EXPORT_SYMBOL (spi_populate_ppr_msg);#ifdef CONFIG_SCSI_CONSTANTS static const char * const one_byte_msgs[] = {
Quoted 1 line · Matthew Wilcox
These functions should be usable by modules.
since this is new and very much linux specific code, shouldn't these be _GPL exports?
Quoted 2 lines · Arjan van de Ven
since this is new and very much linux specific code, shouldn't these be
_GPLexports?
Actually, try this commit:
It's been there since I put the patch in ... otherwise none of my modules would build ...
James
Quoted 5 lines · Arjan van de Ven
Quoted 1 line · Matthew Wilcox
These functions should be usable by modules.
since this is new and very much linux specific code, shouldn't these be
_GPLexports?
how is it very much linux specific? these functions take a char pointer and fill in that buffer with the messages defined in the scsi specs. there's no linux data structures used.
Quoted 10 lines · James Bottomley
Quoted 2 lines · Arjan van de Ven
since this is new and very much linux specific code, shouldn't these be
_GPLexports?Actually, try this commit:
It's been there since I put the patch in ... otherwise none of my modules would build ...
How strange; when I looked on gitweb an hour ago, it wasn't there, yet now it is.