Skip to contentSkip to conversation

check request_region() return value in arch/ppc and

PATCH Nishanth Aravamudan 1 participant 1 message Feb 27, 2006 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 8 lines · Tim Cooijmans

From: Tim Cooijmans <[email protected]>

Check request_region() return value and warn on failure. Note that releasing succeeded requests doesn't make much sense, as the calling code doesn't know if anything failed.

The powerpc code has been compile tested. The ppc code has not been tested, but the changes are very similar.

Looks good in general, one small nit.

Quoted 6 lines

---
diff -uprN linux-2.6.16-rc5-orig/arch/powerpc/platforms/chrp/setup.c linux-2.6.16-rc5/arch/powerpc/platforms/chrp/setup.c

arch/powerpc/platforms/chrp/setup.c void __init chrp_init_IRQ(void) · line 472

Quoted 8 lines
arch/powerpc/platforms/chrp/setup.c +5 -0
@@ -465,18 +465,26 @@ void __init chrp_init_IRQ(void)
 }
 
 void __init
+chrp_request_region(unsigned long start, unsigned long n, char *desc)
+{
+	if (!request_region(start, n, desc)) {
+		printk(KERN_WARNING "CHRP: unable to allocate %s region.\n", desc);
+	}

Here and in the other request_region() wrappers, no { } for the one-line if, please.

Thanks,
Nish

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors