chelsio/espi.c:tricn_init(): remove dead code
Subsystems (2)
RFC PATCH 1/1 chelsio/espi.c:tricn_init(): remove dead code
The Coverity checker spotted these two unused variables.
Please check whether this patch is correct or whether they should be used.
Signed-off-by Adrian Bunk <[email protected]>
---
drivers/net/chelsio/espi.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)
drivers/net/chelsio/espi.c renamed from drivers/net/chelsio/espi.c.old +3 -11
@@ -87,15 +87,9 @@static int tricn_init (adapter_t *adapter) {int i =0 ; -int sme =1 ;int stat =0 ;int timeout =0 ;int is_ready =0 ; -int dynamic_deskew =0 ; - -if (dynamic_deskew) - sme =0 ; -/* 1 */ timeout=1000 ;
@@ -113,11 +107,9 @@ }/* 2 */ -if (sme) { -tricn_write (adapter,0 ,0 ,0 ,TRICN_CNFG ,0x81 ); -tricn_write (adapter,0 ,1 ,0 ,TRICN_CNFG ,0x81 ); -tricn_write (adapter,0 ,2 ,0 ,TRICN_CNFG ,0x81 ); - } +tricn_write (adapter,0 ,0 ,0 ,TRICN_CNFG ,0x81 ); +tricn_write (adapter,0 ,1 ,0 ,TRICN_CNFG ,0x81 ); +tricn_write (adapter,0 ,2 ,0 ,TRICN_CNFG ,0x81 );for (i=1 ; i<=8 ; i++)tricn_write (adapter,0 ,0 , i,TRICN_CNFG ,0xf1 );for (i=1 ; i<=2 ; i++)tricn_write (adapter,0 ,1 , i,TRICN_CNFG ,0xf1 );for (i=1 ; i<=3 ; i++)tricn_write (adapter,0 ,2 , i,TRICN_CNFG ,0xe1 );
This patch is correct, these two variables are unused in this driver. Thanks for catching this!
Signed-off-by Scott Bardone <[email protected]>
Quoted 46 lines · Adrian Bunk
The Coverity checker spotted these two unused variables.
Please check whether this patch is correct or whether they should be used.
Signed-off-by Adrian Bunk <[email protected]>---
drivers/net/chelsio/espi.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)drivers/net/chelsio/espi.c renamed from drivers/net/chelsio/espi.c.old +3
-11@@ -87,15 +87,9 @@static int tricn_init (adapter_t *adapter) {int i =0 ; -int sme =1 ;int stat =0 ;int timeout =0 ;int is_ready =0 ; -int dynamic_deskew =0 ; - -if (dynamic_deskew) - sme =0 ; -/* 1 */ timeout=1000 ;@@ -113,11 +107,9 @@ }/* 2 */ -if (sme) { -tricn_write (adapter,0 ,0 ,0 ,TRICN_CNFG ,0x81 ); -tricn_write (adapter,0 ,1 ,0 ,TRICN_CNFG ,0x81 ); -tricn_write (adapter,0 ,2 ,0 ,TRICN_CNFG ,0x81 ); - } +tricn_write (adapter,0 ,0 ,0 ,TRICN_CNFG ,0x81 ); +tricn_write (adapter,0 ,1 ,0 ,TRICN_CNFG ,0x81 ); +tricn_write (adapter,0 ,2 ,0 ,TRICN_CNFG ,0x81 );for (i=1 ; i<=8 ; i++)tricn_write (adapter,0 ,0 , i,TRICN_CNFG ,0xf1 );for (i=1 ; i<=2 ; i++)tricn_write (adapter,0 ,1 , i,TRICN_CNFG ,0xf1 );for (i=1 ; i<=3 ; i++)tricn_write (adapter,0 ,2 , i,TRICN_CNFG ,0xe1 );