Skip to contentSkip to conversation

md/bitmap.c:bitmap_mask_state(): fix inconsequent NULL checking

PATCH New Adrian Bunk 1 participant 1 message Mar 10, 2006 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 md/bitmap.c:bitmap_mask_state(): fix inconsequent NULL checking

We dereference bitmap both one line above and one line below this check rendering this check quite useless.

Spotted by the Coverity checker.

drivers/md/bitmap.c renamed from drivers/md/bitmap.c.old +1 -1
@@ -546,7 +546,7 @@ static void bitmap_mask_state(struct bit
 	unsigned long flags;
 
 	spin_lock_irqsave(&bitmap->lock, flags);
-	if (!bitmap || !bitmap->sb_page) { /* can't set the state */
+	if (!bitmap->sb_page) { /* can't set the state */
 		spin_unlock_irqrestore(&bitmap->lock, flags);
 		return;
 	}