Skip to contentSkip to conversation

Input: psmouse - disable autoresync

PATCH In review Dmitry Torokhov 2 participants 4 messages Mar 11, 2006 – Mar 12, 2006 Input drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: psmouse - disable autoresync

Automatic resynchronization in psmouse driver causes problems on some hardware so disable it by default for now. People with KVM switches that require resync can still enable it via module parameter or sysfs attribute.

---

Unfortunately I could not spend enouggh time during 2.6.16 cycle to resolve all issues with the code so we better turn it off by default for now.

 drivers/input/mouse/psmouse-base.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/input/mouse/psmouse-base.c +1 -1
Index: work/drivers/input/mouse/psmouse-base.c
===================================================================
@@ -60,7 +60,7 @@ static unsigned int psmouse_resetafter =
 module_param_named(resetafter, psmouse_resetafter, uint, 0644);
 MODULE_PARM_DESC(resetafter, "Reset device after so many bad packets (0 = never).");
 
-static unsigned int psmouse_resync_time = 5;
+static unsigned int psmouse_resync_time;
 module_param_named(resync_time, psmouse_resync_time, uint, 0644);
 MODULE_PARM_DESC(resync_time, "How long can mouse stay idle before forcing resync (in seconds, 0 = never).");
 
#1 lore raw
Quoted 4 lines · Dmitry Torokhov

Automatic resynchronization in psmouse driver causes problems on some hardware so disable it by default for now. People with KVM switches that require resync can still enable it via module parameter or sysfs attribute.

Shouldn't the default be the other way round.. Existing *compatible* behaviour by default, and those who need it can do psmouse.resync_time=0

????????????????

#2 lore raw
Quoted 6 lines · Mark Lord
Quoted 4 lines · Dmitry Torokhov

Automatic resynchronization in psmouse driver causes problems on some hardware so disable it by default for now. People with KVM switches that require resync can still enable it via module parameter or sysfs attribute.

Quoted 6 lines

Shouldn't the default be the other way round.. Existing *compatible* behaviour by default, and those who need it can do psmouse.resync_time=0

????????????????

Automatic resync code was added at the beginning of 2.6.16 and although it generally works quite well and usually resolves problems caused by KVMs resetting mice ther were several reports of it breaking existing setups. Unfortunately I did not have anough time to resolve the issues in time for 2.6.16 final and so I think it is the best to disable new code by default for now. I do not want to revert the changes completely as they are still useful.

Hope this helps.

Signature · 1 line
Dmitry
#3 lore raw
Quoted 7 lines · Dmitry Torokhov

Automatic resync code was added at the beginning of 2.6.16 and although it generally works quite well and usually resolves problems caused by KVMs resetting mice ther were several reports of it breaking existing setups. Unfortunately I did not have anough time to resolve the issues in time for 2.6.16 final and so I think it is the best to disable new code by default for now. I do not want to revert the changes completely as they are still useful.

Ah, okay. Thank! I need this patch on my server here!

Cheers