drivers/block/paride/pd.c: fix an off-by-one
PATCH 1/1 drivers/block/paride/pd.c: fix an off-by-one
The Coverity checker found this off-by-one error.
Signed-off-by Adrian Bunk <[email protected]>
drivers/block/paride/pd.c renamed from drivers/block/paride/pd.c.old +1 -1
@@ -275,7 +275,7 @@int i;printk ("%s: %s: status = 0x%x =" , disk->name, msg, status); -for (i =0 ; i <18 ; i++) +for (i =0 ; i <17 ; i++)if (status & (1 << i))printk (" %s" , pd_errs[i]);printk ("\n" );
Quoted 8 lines · On Sat, 11 Mar 2006 04:42:53 +0100 Adrian Bunk wrote:
The Coverity checker found this off-by-one error.
Signed-off-by Adrian Bunk <[email protected]>
drivers/block/paride/pd.c line 281
Quoted 8 lines
drivers/block/paride/pd.c renamed from drivers/block/paride/pd.c.old +1
-1@@ -275,7 +275,7 @@int i;printk ("%s: %s: status = 0x%x =" , disk->name, msg, status); -for (i =0 ; i <18 ; i++) +for (i =0 ; i <17 ; i++)if (status & (1 << i))printk (" %s" , pd_errs[i]);printk ("\n" );
Please use ARRAY_SIZE(pd_errs)
and #include <linux/kernel.h>
---
~Randy
Please use an email client that implements proper (compliant) threading. (You know who you are.)
PATCH 1/1 drivers/block/paride/pd.c: fix an off-by-one error
Quoted 12 lines · Randy.Dunlap
Quoted 10 lines · On Sat, 11 Mar 2006 04:42:53 +0100 Adrian Bunk wrote:
The Coverity checker found this off-by-one error.
Signed-off-by Adrian Bunk <[email protected]>drivers/block/paride/pd.c renamed from drivers/block/paride/pd.c.old +0
-0@@ -275,7 +275,7 @@int i;
Quoted 9 lines
drivers/block/paride/pd.c line 281
Quoted 6 lines
drivers/block/paride/pd.c renamed from drivers/block/paride/pd.c.old +1
-1printk ("%s: %s: status = 0x%x =" , disk->name, msg, status); -for (i =0 ; i <18 ; i++) +for (i =0 ; i <17 ; i++)if (status & (1 << i))printk (" %s" , pd_errs[i]);printk ("\n" );Please use
ARRAY_SIZE(pd_errs)
and #include <linux/kernel.h>
Sounds reasonable, updated patch below.
Quoted 1 line
~Randy
cu
Adrian
<-- snip -->
The Coverity checker found this off-by-one error.
Signed-off-by Adrian Bunk <[email protected]>
---
drivers/block/paride/pd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/block/paride/pd.c renamed from drivers/block/paride/pd.c.old +2 -1
@@ -151,6 +151,7 @@ enum {D_PRT, D_PRO, D_UNI, D_MOD, D_GEO,#include <linux/cdrom.h> /* for the eject ioctl */ #include <linux/blkdev.h> #include <linux/blkpg.h> +#include <linux/kernel.h> #include <asm/uaccess.h> #include <linux/sched.h> #include <linux/workqueue.h>
@@ -275,7 +276,7 @@ static void pd_print_error(struct pd_uniint i;printk ("%s: %s: status = 0x%x =" , disk->name, msg, status); -for (i =0 ; i <18 ; i++) +for (i =0 ; i <ARRAY_SIZE (pd_errs); i++)if (status & (1 << i))printk (" %s" , pd_errs[i]);printk ("\n" );