Skip to contentSkip to conversation

mark init related functions/variable with __init declaration

PATCH In review Chen, Kenneth W 1 participant 2 messages Mar 12, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mark init related functions/variable with __init declaration

Speaking of the devil, bunch of functions and variable in mca.c can be marked with __init variants.

arch/ia64/kernel/mca.c renamed from arch/ia64/kernel/mca.c.orig +4 -4
@@ -133,7 +133,7 @@ static int cpe_poll_enabled = 1;
 
 extern void salinfo_log_wakeup(int type, u8 *buffer, u64 size, int irqsafe);
 
-static int mca_init;
+static int __initdata mca_init;
 
 
 static void inline
@@ -184,7 +184,7 @@ static ia64_state_log_t ia64_state_log[I
  * Inputs   :   info_type   (SAL_INFO_TYPE_{MCA,INIT,CMC,CPE})
  * Outputs	:	None
  */
-static void
+static void __init
 ia64_log_init(int sal_info_type)
 {
 	u64	max_size = 0;
@@ -392,7 +392,7 @@ ia64_mca_register_cpev (int cpev)
  * Outputs
  *	None
  */
-void
+void __devinit
 ia64_mca_cmc_vector_setup (void)
 {
 	cmcv_reg_t	cmcv;
@@ -1416,7 +1416,7 @@ static struct irqaction mca_cpep_irqacti
  * format most of the fields.
  */
 
-static void
+static void __devinit
 format_mca_init_stack(void *mca_data, unsigned long offset,
 		const char *type, int cpu)
 {
#1 lore raw

Chen, Kenneth W wrote on Saturday, March 11, 2006 5:11 PM

arch/ia64/kernel/mca.c ia64_mca_register_cpev (int cpev) · line 396

Quoted 6 lines

Speaking of the devil, bunch of functions and variable in mca.c can be marked with __init variants.

arch/ia64/kernel/mca.c renamed from arch/ia64/kernel/mca.c.orig +1 -1
-void
+void __devinit
 ia64_mca_cmc_vector_setup (void)

Note to self: __cpuinit is probably a better one to use.