Skip to contentSkip to conversation

i386 Vmi module fixups

RFC PATCH In review Zachary Amsden 1 participant 1 message Mar 13, 2006

lore
Share & tools
lore
#0 lore raw

RFC PATCH 20/24 i386 Vmi module fixups

Add a sub-arch specifier to the module identification string to avoid cross loading modules from different subarch compiles.

XXX FIXME. Module loading is broken in paravirtualized VMI kernels, since there is no annotation fixup applied to modules.

include/asm-i386/module.h +4 -1
Index: linux-2.6.16-rc3/include/asm-i386/module.h
===================================================================
@@ -1,6 +1,8 @@
 #ifndef _ASM_I386_MODULE_H
 #define _ASM_I386_MODULE_H
 
+#include <mach_module.h>
+
 /* x86 is simple */
 struct mod_arch_specific
 {
@@ -72,6 +74,7 @@ struct mod_arch_specific
 #define MODULE_STACKSIZE ""
 #endif
 
-#define MODULE_ARCH_VERMAGIC MODULE_PROC_FAMILY MODULE_REGPARM MODULE_STACKSIZE
+#define MODULE_ARCH_VERMAGIC MODULE_PROC_FAMILY MODULE_REGPARM MODULE_STACKSIZE \
+	MODULE_SUBARCH_VERMAGIC
 
 #endif /* _ASM_I386_MODULE_H */
include/asm-i386/mach-vmi/mach_module.h +6 -0
Index: linux-2.6.16-rc3/include/asm-i386/mach-vmi/mach_module.h
===================================================================
@@ -0,0 +1,6 @@
+#ifndef _ASM_I386_ARCH_MODULE_H
+#define _ASM_I386_ARCH_MODULE_H
+
+#define MODULE_SUBARCH_VERMAGIC "VMI "
+
+#endif /* _ASM_I386_ARCH_MODULE_H */
include/asm-i386/mach-default/mach_module.h +6 -0
Index: linux-2.6.16-rc3/include/asm-i386/mach-default/mach_module.h
===================================================================
@@ -0,0 +1,6 @@
+#ifndef _ASM_I386_ARCH_MODULE_H
+#define _ASM_I386_ARCH_MODULE_H
+
+#define MODULE_SUBARCH_VERMAGIC
+
+#endif /* _ASM_I386_ARCH_MODULE_H */