Skip to contentSkip to conversation

Hamradio: Fix a NULL pointer dereference in net/hamradio/6pack.c

PATCH In review Eugene Teo 2 participants 3 messages Mar 16, 2006 Network drivers

lore
Share & tools
lore

Eugene Teo

author
#0 lore raw

PATCH 1/1 Hamradio: Fix a NULL pointer dereference in net/hamradio/6pack.c

Pointer sp is dereferenced before NULL check.

Coverity bug #816

drivers/net/hamradio/6pack.c renamed from drivers/net/hamradio/6pack.c~ +5 -2
@@ -726,13 +726,16 @@ static void sixpack_close(struct tty_str
 static int sixpack_ioctl(struct tty_struct *tty, struct file *file,
 	unsigned int cmd, unsigned long arg)
 {
-	struct sixpack *sp = sp_get(tty);
-	struct net_device *dev = sp->dev;
+	struct sixpack *sp;
+	struct net_device *dev;
 	unsigned int tmp, err;
 
 	if (!sp)
 		return -ENXIO;
 
+	sp = sp_get(tty);
+	dev = sp->dev;
+
 	switch(cmd) {
 	case SIOCGIFNAME:
 		err = copy_to_user((void __user *) arg, dev->name,
Signature · 2 lines
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265  9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
author
#1 lore raw

<quote sender="Eugene Teo">

Quoted 5 lines

Pointer sp is dereferenced before NULL check.

Coverity bug #816

Ignore the previous patch please. Here's a resend.

--
Pointer sp is dereferenced before NULL check.

Coverity bug #816

drivers/net/hamradio/6pack.c renamed from drivers/net/hamradio/6pack.c~ +3 -1
@@ -727,12 +727,14 @@ static int sixpack_ioctl(struct tty_stru
 	unsigned int cmd, unsigned long arg)
 {
 	struct sixpack *sp = sp_get(tty);
-	struct net_device *dev = sp->dev;
+	struct net_device *dev;
 	unsigned int tmp, err;
 
 	if (!sp)
 		return -ENXIO;
 
+	dev = sp->dev;
+
 	switch(cmd) {
 	case SIOCGIFNAME:
 		err = copy_to_user((void __user *) arg, dev->name,
Signature · 2 lines
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265  9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }