TAKE 949916 - direct read vs delalloc
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 2 lines · Nathan Scott
Flush and invalidate dirty pages at the start of a direct read also, else we can hit a delalloc-extents-via-direct-io BUG.
If this is needed it should be done in the filemap.c code.
Quoted 5 lines
Date: Fri Mar 17 16:29:59 AEDT 2006 Workarea: chook.melbourne.sgi.com:/build/nathans/xfs-linux Inspected by: tes
Quoted 9 lines
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/xfs-kern/xfs-linux-melbModid: xfs-linux-melb:xfs-kern:25483a
linux-2.6/xfs_lrw.c- 1.237 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_lrw.c.diff?r1=text&tr1=1.237&r2=text&tr2=1.236&f=h
---end quoted text---
Quoted 5 lines · Christoph Hellwig
Quoted 2 lines · Nathan Scott
Flush and invalidate dirty pages at the start of a direct read also, else we can hit a delalloc-extents-via-direct-io BUG.
If this is needed it should be done in the
filemap.ccode.
Hmm, maybe, maybe not.
filemap.c code doesn't know much about delayed allocation, so this won't bite other filesystems. We do the same thing on write and always have, so having it inside XFS is OK by me.
cheers.
Signature · 1 line
Nathan