Skip to contentSkip to conversation

OSS msnd_pinnacle missing return check for request_region()

PATCH New Laurent Wandrebeck 1 participant 1 message Mar 17, 2006 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OSS msnd_pinnacle missing return check for request_region()

Hi,
in sound/oss/msnd_pinnacle.c, request_region() is called without checking the return value. Here is a simple patch to fix it.
Patch against 2.6.16-rc6-git8.
Please CC me on replies.
Regards.
PS: trying with a MUA this time, since the webmail I used for previous patch ( [patch 1/1] OSS ali5455 missing return check for request_region() ) wrapped lines :(

sound/oss/msnd_pinnacle.c 2006-03-17 11:05:42.000000000 +0100 renamed from sound/oss/msnd_pinnacle.c.ori 2006-03-17 10:45:46.000000000 +0100 +7 -1
@@ -1397,7 +1397,13 @@ static int __init attach_multisound(void
                printk(KERN_ERR LOGNAME ": Couldn't grab IRQ %d\n", dev.irq);
                return err;
        }
-       request_region(dev.io, dev.numio, dev.name);
+
+       if (!request_region(dev.io, dev.numio, dev.name)) {
+               printk(KERN_ERR LOGNAME ": Unable to reserve region %d\n",
+                                dev->io);
+               free_irq(dev.irq,&dev);
+               return -EBUSY;
+       }
 
         if ((err = dsp_full_reset()) < 0) {
                release_region(dev.io, dev.numio);