Skip to contentSkip to conversation

Fix resource leak in isapnp

PATCH New Jesper Juhl 1 participant 1 message Mar 18, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix resource leak in isapnp

We may leak memory in drivers/pnp/isapnp/core.c::isapnp_create_device() Spotted by the Coverity checker as bug #666 - this should fix it.

---

 drivers/pnp/isapnp/core.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletion(-)
drivers/pnp/isapnp/core.c +3 -1
@@ -646,8 +646,10 @@ static int __init isapnp_create_device(s
 				size = 0;
 				skip = 0;
 				option = pnp_register_independent_option(dev);
-				if (!option)
+				if (!option) {
+					kfree(dev);
 					return 1;
+				}
 				pnp_add_card_device(card,dev);
 			} else {
 				skip = 1;