Skip to contentSkip to conversation

saa7111.c patch

PATCH Martin Samuelsson 2 participants 2 messages Mar 19, 2006 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hello.

When grabbing composite video with Iomega Buz, the stock driver will prevent grabbing from the same input twice in a row, forcing the user to switch inputs before anything useful can be grabbed again. It is caused by some optimization code in the input selection parts, and triggered by the saa7111_command() executing cmd 0. The attached patch will remedy this by disabling cmd 0 altogether; a fix that has no found negative effects on the rest of the code. In fact, saa7110.c does the exact same thing.

It would be nice to have this included in the kernel driver.

I'd appreciate being kept in the recipient list in case of discussion.

Regards,
/Sam

drivers/media/video/saa7111.c +1 -0
@@ -210,6 +210,7 @@
 	switch (cmd) {
 
 	case 0:
+	  break;
 	case DECODER_INIT:
 	{
 		struct video_decoder_init *init = arg;
#1 lore raw

Hi,

Quoted 8 lines · Martin Samuelsson

When grabbing composite video with Iomega Buz, the stock driver will prevent grabbing from the same input twice in a row, forcing the user to switch inputs before anything useful can be grabbed again. It is caused by some optimization code in the input selection parts, and triggered by the saa7111_command() executing cmd 0. The attached patch will remedy this by disabling cmd 0 altogether; a fix that has no found negative effects on the rest of the code. In fact, saa7110.c does the exact same thing.

I second this patch, can you please add it to your tree? Thanks,

Ronald