Skip to contentSkip to conversation

powerpc: Move pSeries firmware feature setup into platforms/pseries

PATCH Dave Jones 3 participants 7 messages Mar 29, 2006 1 message not in the archive

lore
Share & tools
lore

Dave Jones

author
#1 lore raw
In reply to a message not in the archive
Quoted 10 lines · Linux Kernel

commit 1965746bce49ddf001af52c7985e16343c768021
tree d311fce31613545f3430582322d66411566f1863
parent 0941d57aa7034ef7010bd523752c2e3bee569ef1
author Michael Ellerman <[email protected]> Fri, 10 Feb 2006 15:47:36 +1100 committer Paul Mackerras <[email protected]> Fri, 10 Feb 2006 16:52:03 +1100

[PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries

Currently we have some stuff in firmware.h and kernel/firmware.c that is #ifdef CONFIG_PPC_PSERIES. Move it all into platforms/pseries.

This (or one of the other firmware patches, I've not narrowed it down that close) breaks ppc64 oprofile.

modpost now complains with..

kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#2 lore raw
Quoted 6 lines · Dave Jones

This (or one of the other firmware patches, I've not narrowed it down that close) breaks ppc64 oprofile.

modpost now complains with..

kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features

That got renamed to powerpc_firmware_features. I don't see any occurrences of ppc64_firmware_features left anywhere in the tree. Are you sure you don't just need to make clean and rebuild?

Paul.

author
#3 lore raw
Quoted 5 lines · Paul Mackerras
Quoted 3 lines · Dave Jones

This (or one of the other firmware patches, I've not narrowed it down that close) breaks ppc64 oprofile.

Quoted 7 lines
Quoted 3 lines

modpost now complains with..

kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features

That got renamed to powerpc_firmware_features. I don't see any occurrences of ppc64_firmware_features left anywhere in the tree. Are you sure you don't just need to make clean and rebuild?

See firmware_has_feature() in include/asm-powerpc/firmware.h

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#6 lore raw
In reply to Dave Jones
Quoted 12 lines · Dave Jones
Quoted 10 lines · Linux Kernel

commit 1965746bce49ddf001af52c7985e16343c768021
tree d311fce31613545f3430582322d66411566f1863
parent 0941d57aa7034ef7010bd523752c2e3bee569ef1
author Michael Ellerman <[email protected]> Fri, 10 Feb 2006 15:47:36 +1100 committer Paul Mackerras <[email protected]> Fri, 10 Feb 2006 16:52:03 +1100

[PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries

Currently we have some stuff in firmware.h and kernel/firmware.c that is #ifdef CONFIG_PPC_PSERIES. Move it all into platforms/pseries.

Quoted 6 lines

This (or one of the other firmware patches, I've not narrowed it down that close) breaks ppc64 oprofile.

modpost now complains with..

kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features

Hi Dave,

I'm not sure about that patch, but I think the firmware feature stuff has been broken for modules for a while, we weren't exporting ppc64_firmware_features anywhere.

The fix just got merged in the last day or so:
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d0160bf0b3e87032be8e85f80ddd2f18e107b86f

cheers

Signature · 8 lines
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
author
#7 lore raw
Quoted 18 lines · Michael Ellerman
Quoted 17 lines · Dave Jones
Quoted 10 lines · Linux Kernel

commit 1965746bce49ddf001af52c7985e16343c768021
tree d311fce31613545f3430582322d66411566f1863
parent 0941d57aa7034ef7010bd523752c2e3bee569ef1
author Michael Ellerman <[email protected]> Fri, 10 Feb 2006 15:47:36 +1100 committer Paul Mackerras <[email protected]> Fri, 10 Feb 2006 16:52:03 +1100

[PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries

Currently we have some stuff in firmware.h and kernel/firmware.c that is #ifdef CONFIG_PPC_PSERIES. Move it all into platforms/pseries.

This (or one of the other firmware patches, I've not narrowed it down that close) breaks ppc64 oprofile.

modpost now complains with..

Quoted 7 lines
Quoted 1 line

kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features

Hi Dave,

I'm not sure about that patch, but I think the firmware feature stuff has been broken for modules for a while, we weren't exporting ppc64_firmware_features anywhere.

It's bizarre that it's only just started complaining about it. (I get a nice mail from our buildsystem when a kernel package is built with
unresolved symbols), and the 2.6.16.1 kernel happily sails through.

Quoted 2 lines

The fix just got merged in the last day or so:
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d0160bf0b3e87032be8e85f80ddd2f18e107b86f

still broken with that diff. (I just tested -git15)

firmware_has_feature() needs fixing up.

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#4 lore raw
In reply to Dave Jones
Quoted 1 line · Dave Jones

See firmware_has_feature() in include/asm-powerpc/firmware.h

In my clone of Linus' linux-2.6 tree, it looks like this:

#define firmware_has_feature(feature)					\
	((FW_FEATURE_ALWAYS & (feature)) ||				\
		(FW_FEATURE_POSSIBLE & powerpc_firmware_features & (feature)))

Perhaps you need to do another pull?

Paul.

author
#5 lore raw
Quoted 11 lines · Paul Mackerras
Quoted 1 line · Dave Jones

See firmware_has_feature() in include/asm-powerpc/firmware.h

In my clone of Linus' linux-2.6 tree, it looks like this:

#define firmware_has_feature(feature)					\
	((FW_FEATURE_ALWAYS & (feature)) ||				\
		(FW_FEATURE_POSSIBLE & powerpc_firmware_features & (feature)))

Perhaps you need to do another pull?

Ah, it hadn't made it into a -git release yet. git17 was still busted.
I see the commit on the commits-list though, so I'll just twiddle my thumbs until git18 :-)

thanks,

Dave

Signature · 1 line
http://www.codemonkey.org.uk