Skip to contentSkip to conversation

x86_64: Force broadcast timer on AMD systems with C3 too.

PATCH Dave Jones 1 participant 1 message Mar 26, 2006 1 message not in the archive

lore
Share & tools
lore

Dave Jones

author
#1 lore raw
In reply to a message not in the archive
Quoted 7 lines · Linux Kernel

commit bd6633476922b7b51227f7f704c2546e763ae5ed
tree 4e9844781419fe600c3e9f3e9dab8207f8dd12dd
parent 7682968b7d4d42bb076051b962c3926b4c98539a
author Andi Kleen <[email protected]> Sat, 25 Mar 2006 16:31:07 +0100 committer Linus Torvalds <[email protected]> Sun, 26 Mar 2006 01:10:56 -0800

[PATCH] x86_64: Force broadcast timer on AMD systems with C3 too.

this breaks ia64.

drivers/acpi/processor_idle.c: In function 'acpi_processor_power_verify':
drivers/acpi/processor_idle.c:919: error: 'switch_APIC_timer_to_ipi' undeclared (first use in this function) drivers/acpi/processor_idle.c:919: error: (Each undeclared identifier is reported only once drivers/acpi/processor_idle.c:919: error: for each function it appears in.)

Quoted 11 lines

#ifdef ARCH_APICTIMER_STOPS_ON_C3

(quoted diff) +2 -4
-			if (cx->valid && c->x86_vendor == X86_VENDOR_INTEL) {
-				on_each_cpu(switch_APIC_timer_to_ipi,
-						&mask, 1, 1);
-			}
+			if (cx->valid)
+				timer_broadcast++;
 #endif
 			break;
 		}

Review static int acpi_processor_power_verify(s · line 920

Quoted 6 lines
(quoted diff) +3 -0
@@ -913,6 +915,9 @@ static int acpi_processor_power_verify(s
 			working++;
 	}
 
+	if (timer_broadcast)
+		on_each_cpu(switch_APIC_timer_to_ipi, &mask, 1, 1);
+

Looks like it needs wrapping in that ifdef ?

Dave

Signature · 1 line
http://www.codemonkey.org.uk