Skip to contentSkip to conversation

Capture selinux subject/object context information.

PATCH James Morris 2 participants 2 messages Mar 27, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 12 lines · Linux Kernel Mailing List

commit 8c8570fb8feef2bc166bee75a85748b25cda22d9
tree ed783d405ea9d5f3d3ccc57fb56c7b7cb2cdfb82
parent c8edc80c8b8c397c53f4f659a05b9ea6208029bf
author Dustin Kirkland <[email protected]> Thu, 03 Nov 2005 17:15:16 +0000 committer Al Viro <[email protected]> Tue, 21 Mar 2006 00:08:54 -0500

[PATCH] Capture selinux subject/object context information.

include/linux/security.h struct swap_info_struct; · line 876

Quoted 8 lines
include/linux/security.h +5 -0
@@ -869,6 +869,11 @@ struct swap_info_struct;
  *	@ipcp contains the kernel IPC permission structure
  *	@flag contains the desired (requested) permission set
  *	Return 0 if permission is granted.
+ * @ipc_getsecurity:
+ *      Copy the security label associated with the ipc object into
+ *      @buffer.  @buffer may be NULL to request the size of the buffer 
+ *      required.  @size indicates the size of @buffer in bytes. Return 
+ *      number of bytes used/required on success.

I may have missed it, but was this change discussed on the LSM list?

include/linux/security.h struct swap_info_struct; · line 877

Quoted 1 line
include/linux/security.h +1 -0
+	char *(*inode_xattr_getsuffix) (void);

Not documented?

include/linux/security.h struct swap_info_struct;

Quoted 10 lines
include/linux/security.h +0 -8
 static int selinux_inode_getsecurity(struct inode *inode, const char *name, void *buffer, size_t size, int err)
 
-	if (err > 0) {
-		if ((len == err) && !(memcmp(context, buffer, len))) {
-			/* Don't need to canonicalize value */
-			rc = err;
-			goto out_free;
-		}
-		memset(buffer, 0, size);
-	}

Where did this functionality go?

- James

Signature · 2 lines
James Morris
<[email protected]>
#2 lore raw
Quoted 11 lines · James Morris
Quoted 8 lines · Linux Kernel Mailing List

commit 8c8570fb8feef2bc166bee75a85748b25cda22d9
tree ed783d405ea9d5f3d3ccc57fb56c7b7cb2cdfb82
parent c8edc80c8b8c397c53f4f659a05b9ea6208029bf
author Dustin Kirkland <[email protected]> Thu, 03 Nov 2005 17:15:16 +0000 committer Al Viro <[email protected]> Tue, 21 Mar 2006 00:08:54 -0500

[PATCH] Capture selinux subject/object context information.

Quoted 13 lines

include/linux/security.h struct swap_info_struct; · line 876

Quoted 11 lines
include/linux/security.h +5 -0
@@ -869,6 +869,11 @@ struct swap_info_struct;
  *	@ipcp contains the kernel IPC permission structure
  *	@flag contains the desired (requested) permission set
  *	Return 0 if permission is granted.
+ * @ipc_getsecurity:
+ *      Copy the security label associated with the ipc object into
+ *      @buffer.  @buffer may be NULL to request the size of the buffer 
+ *      required.  @size indicates the size of @buffer in bytes. Return 
+ *      number of bytes used/required on success.

I may have missed it, but was this change discussed on the LSM list?

No, it was discussed on redhat-lspp and linux-audit.

Quoted 7 lines

include/linux/security.h struct swap_info_struct; · line 877

Quoted 2 lines
include/linux/security.h +1 -0
+	char *(*inode_xattr_getsuffix) (void);

Not documented?

Quoted 1 line
include/linux/security.h +0 -0
 static int selinux_inode_getsecurity(struct inode *inode, const char *name, void *buffer, size_t size, int err)
Quoted 10 lines

include/linux/security.h struct swap_info_struct;

Quoted 8 lines
include/linux/security.h +0 -8
-	if (err > 0) {
-		if ((len == err) && !(memcmp(context, buffer, len))) {
-			/* Don't need to canonicalize value */
-			rc = err;
-			goto out_free;
-		}
-		memset(buffer, 0, size);
-	}

Where did this functionality go?

I raised the same concern in Dec (subj: audit patches in -mm that alter current SELinux behavior), but concluded that falling through to selinux_getsecurity() in all cases does no harm and the real cost here is in the generation of the context string, so we don't save much by the shortcut that was removed above.

Signature · 2 lines
Stephen Smalley
National Security Agency